shrine virus scan plugin #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markolson
approved these changes
May 17, 2017
|
pinging @kreek and @markolson to see what should happen with this? |
|
@ayaleloehr it can be merged now, was waiting on devops PR but that looks like it was merged on Friday https://github.com/department-of-veterans-affairs/devops/pull/1702 |
saneshark
added a commit
that referenced
this pull request
Jun 20, 2017
* Save spec results to enable --only-failures option * Update nokogiri to latest version per Brakeman CVE vulnerability finding (#1052) * rename residence_hours & distance_hours to on_campus_hours & online hours respectively to match EVSS (#1050) * shrine virus scan plugin (#948) * Add data to gibs mock response * Fix typo * Fix typo * More fixes * Fix date * Return listings of InprogressForms * 5490 transform form (#990) * update json schema * copy info from previous benefits * rerun tests * update vets json schema * copy_from_previous_benefits spec * Serializer shouldn't be bound to ActiveRecord methods * add simplecov filter for vendor dir (#1032) * Addition of Vet Centers to API (#1025) * VHA facility access worker (#1054) * Bulk download of facility access data, insertion into cache * Wire cached access data to facility model * Appeals for reals (#1048) * start hitting the real demo appeals service * narrow down crash * tweakin * run the appeals against the demo service * add comment * remove bad copy/paste * Feature Gate Prefill to only work for test users Anything in the 79*-**-**** pattern isn't a valid SSN, so this should limit it to just our test accounts. * Updated evss readme with letters and GIBS mock service instructions (#1058) * Initial HCA Prefill work using MVI data Starts a refactor for FormProfile as well, where each type of form can provide extra details like default metadata for the frontend prefill code. * adding /v0/letters/beneficiary endpoint (#1061) * Tidy some code * Fix a sometimes failing spec * Enable an accidentally disabled spec * Log health record refresh error info to Sentry (#1065) * Add a destroy action for in progress forms * Fix a seed-based spec failure The Swagger spec creates 2 TermsAndService instances, which use Faker underneath. If Faker returns the same string for both instances, an association lookup with fail to pick the correct instance and a spec will fail. This makes the lookup value explicitely different. Tested with `bundle exec rspec spec/request/swagger_spec.rb:550 --seed 55395` against 04eac2 * Include expires_at in SIP response. Prune old records * Allow dynamic text in PDF Stamping More than just the Vets.gov stamp and coords, we may want to stamp a confirmation number or some other data to the PDFs. * Fix another failing spec related to T&C Tested with `--seed 42804` on `da84be` * add mock mvi users for evss (#1057) * Refer to prefills by their form identifier, and list them to users * add CI users to mock mvi data (#1080) * adding rubocop exception for user_serializer#sergices * fixing indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.