Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README: Get cert before running setup script #939

Merged
merged 5 commits into from
Apr 25, 2017

Conversation

cvalarida
Copy link
Contributor

I ran the automated script without setting up the cert first and got an error because it expected it. I got the cert, reran the script, and it all worked out.

Not sure who to ask for a review from, so I'll just @mention GitHub's suggested reviewers, @knkski, @robbiethegeek, and @markolson.

I ran the automated script without setting up the cert first and got an error because it expected it. I got the cert, reran the script, and it all worked out.
@ayaleloehr
Copy link
Contributor

Also tagging @omgitsbillryan because it's ID.me related.

@jcmeloni-usds
Copy link
Contributor

@jcmeloni-usds
Copy link
Contributor

Oh, this isn't "i have an issue" it's "instructions need to be updated". my bad. will read better in the future.

Copy link
Contributor

@omgitsbillryan omgitsbillryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you

  1. Moved the cert/key section up
  2. Fixed link
  3. Touched up some formatting

Big fat LGTM from me 👍

@markolson
Copy link
Contributor

Maybe we could update bin/setup-osx to touch (or even try to grab) those files too?

@robbiethegeek-usds
Copy link
Contributor

@cvalarida this looks great, I think if you can update the setup-osx and ping @markolson and it should be merged in.

@cvalarida
Copy link
Contributor Author

Yeah, I thought about updating the script, but I'm not super confident in my bash-fu. I'll give it the ol' college try, though!

cvalarida and others added 2 commits April 25, 2017 10:16
Now that the script handles it...partly...
cvalarida added 2 commits April 25, 2017 10:21
@cvalarida cvalarida merged commit bb145bd into master Apr 25, 2017
@cvalarida cvalarida deleted the cvalarida-readme-patch branch April 25, 2017 17:23
@cvalarida
Copy link
Contributor Author

Turns out this became more of a fix-setup-script than a fix-readme kind of branch, but that's for the better. Bash-fu to the rescue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants