-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README: Get cert before running setup script #939
Conversation
I ran the automated script without setting up the cert first and got an error because it expected it. I got the cert, reran the script, and it all worked out.
Also tagging @omgitsbillryan because it's ID.me related. |
Oh, this isn't "i have an issue" it's "instructions need to be updated". my bad. will read better in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you
- Moved the cert/key section up
- Fixed link
- Touched up some formatting
Big fat LGTM from me 👍
Maybe we could update |
@cvalarida this looks great, I think if you can update the setup-osx and ping @markolson and it should be merged in. |
Yeah, I thought about updating the script, but I'm not super confident in my bash-fu. I'll give it the ol' college try, though! |
Now that the script handles it...partly...
…erans-affairs/vets-api into cvalarida-readme-patch
Turns out this became more of a |
I ran the automated script without setting up the cert first and got an error because it expected it. I got the cert, reran the script, and it all worked out.
Not sure who to ask for a review from, so I'll just @mention GitHub's suggested reviewers, @knkski, @robbiethegeek, and @markolson.