Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28785 update faraday connection #7777

Merged
merged 1 commit into from
Aug 31, 2021
Merged

28785 update faraday connection #7777

merged 1 commit into from
Aug 31, 2021

Conversation

dillo
Copy link
Contributor

@dillo dillo commented Aug 30, 2021

Description of change

  • Adding breakers, service_name, request and response type(JSON) to the Faraday connection.

Original issue(s)

department-of-veterans-affairs/va.gov-team#28785

Things to know about this PR

  • RSpec passing
  • Rubocop passing

@dillo dillo requested review from a team as code owners August 30, 2021 16:25
@va-vfs-bot va-vfs-bot temporarily deployed to 28785_update_faraday_request/master/master August 30, 2021 16:46 Inactive
@dillo dillo force-pushed the 28785_update_faraday_request branch from 13472e8 to 09b066b Compare August 30, 2021 17:39
@va-vfs-bot va-vfs-bot temporarily deployed to 28785_update_faraday_request/master/master August 30, 2021 17:50 Inactive
@dillo dillo force-pushed the 28785_update_faraday_request branch from 09b066b to 9647dd6 Compare August 30, 2021 18:55
@dillo dillo force-pushed the 28785_update_faraday_request branch from 9647dd6 to 691599c Compare August 30, 2021 19:15
@va-vfs-bot va-vfs-bot temporarily deployed to 28785_update_faraday_request/master/master August 30, 2021 19:24 Inactive
@dillo dillo merged commit eea0aa6 into master Aug 31, 2021
@dillo dillo deleted the 28785_update_faraday_request branch August 31, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants