Revert "multi-key saml support when decrypting authn responses (#4965)" #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 34fbd2a.
va-vfs-bot
temporarily deployed
to
remove-temp-multikey-support/master
va-vfs-bot
temporarily deployed
to
remove-temp-multikey-support/master
erluti
approved these changes
Oct 1, 2020
reedship
pushed a commit
that referenced
this pull request
Oct 13, 2020
reedship
added a commit
that referenced
this pull request
Oct 29, 2020
* Initial WIP commit of okta app endpoint. Currently work, but needs performance refactoring
* updated controller to remove unnecessary code
* removed unnecessary settings.local.yml file
* Added stub for scopes of returned apps.
Since the app/{app_id}/tokens route is in Early Access, access to this
feature this will be need to be requested from okta. We use EA features
in our connected_applications feature in the user profile, so this
shouldn't be an issue.
Cacheing results is still needed.
* moved app scopes to it's own method
* Added redis cache to index for route
* Refactored controller to call Service instead of performing all logic within the controller
* Added rake task for apps_api
* Updated sidekiq scheduler to include apps_api task
* Small stylistic refactoring and removing dead code
* Fixes to make rubocop happy in apps_api module and changed service files
* removed unnecessary swagger files
* working commit
* updating spec for okta app directory
* added basic request spec file
* added test case to directory_request_spec
* made changes noted by Michael Bastos in PR review
* Added basic swagger files for api documentation
* Fixed code style issues detected by rubocop
* Update database.yml
Removing unnecessary database username
* Delete Gemfile.lock
Gemfile.lock was unintentionally added to commits.
* Delete vcr.log
* Delete Gemfile.lock
* Fixed issues in swagger files found in review by Charley Stran
* small fixes for linter
* jenkins linter fixes
* jenkins linter fixes for controller
* fixed issue with rspec tests config
* rubocop fixes and small refactoring
* Added data normalization and set redis cache
* gemfile.lock
* updated vcr cassette
* rspec test for model
* basic directory function
* rubocop fixes
* updated swagger docs to correct names and descriptions
* base scope endpoint functionality is completed. Also included some model tests.
* Added tests for scopes endpoint.
* fixed small error in rspec
* added unless? block to handle edge case
* removed dead code from previous iterations
* master merge
* rubocop fixes
* fixes from Lindsey Saari's review
* change validation method for DirectoryApplication model
* removing settings.yml change
* 13458 mobile user phone numbers (#5071)
* add PUT /mobile/v0/user/phones
* add phone fields to /mobile/v0/user
* Revert "multi-key saml support when decrypting authn responses (#4965)" (#5009)
This reverts commit 34fbd2a.
* Update text for file upload errors (#5070)
* wip better errors
* fix specs
* hca_attachments
* document and test preeneed attachments
* rescue CarrierWave::IntegrityError
* simplify file upload size validations
* add units for clarity
* start file upload error text cleanup
* file upload error text updates
* update `breakers` gem to version 0.4.0. (#5078)
This version reports "duration" metrics in milliseconds instead of seconds
* added sidekiq-pro and sidekiq-ent
* Update settings.yml
* Update settings.yml
* Update response.rb
old dead code from header response removed
* Migrating from EVSS to BGS on PowerOfAttorneyVerifier (#4683)
* Migrating from EVSS to BGS on PowerOfAttorneyVerifier
* updating claimant
* updating bgs service
* fixing tests
* fixing usermodel to bgs
* fixing all of the BGS and poa stuff
* updating veteran tests
* Removing EVSS power of attorney verifier
* added email and icn to externals
* veteran user test
* fixing tests
* last fix yes
* updating appeals
* removing puts
* removing unecessary json
* updating bgs poa code
* reducing size of Veteran::User
* adding missing json
* stripping first characters for poa code
* final changes to user model
* Update modules/claims_api/spec/services/unsynchronized_evss_claim_service_spec.rb
Thanks for catching this...
Co-authored-by: Ed Mangimelli <38672641+edmangimelli@users.noreply.github.com>
* removing unnecessary headers
Co-authored-by: Ed Mangimelli <38672641+edmangimelli@users.noreply.github.com>
* clear saved "in progress" form upon successful submission of Preneeds Burial form (#5081)
* Add Identifier for BGS Mock Services (#5079)
* bumping bgs gem version
* adding identifier
* adding comment
* removing comment
* updated scopes cassettes to account for change in okta response
* updated spec_helper and scope cassettes
* update vcr url
* update a couple more path
* increased coverage for directory_service.rb
* moved all apps_api related files to apps_api module
* rubocop fix
* Update 20201002143151_create_directory_applications.rb
remove permissions from initial table creation
* Delete 20201012135852_remove_permissions_from_directory_applications.rb
Co-authored-by: Charley Stran <charley.stran@gmail.com>
Co-authored-by: Alastair Dawson <alastair@adhocteam.us>
Co-authored-by: Bill Ryan <bill.ryan@adhocteam.us>
Co-authored-by: Anna Carey <anna@adhocteam.us>
Co-authored-by: Johnny Holton <johnny@oddball.io>
Co-authored-by: Michael Bastos <bastosmichael@gmail.com>
Co-authored-by: Ed Mangimelli <38672641+edmangimelli@users.noreply.github.com>
Co-authored-by: kathleencrawford <53828142+kathleencrawford@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 34fbd2a.
Description of change
We introduced temporary code to support multiple ID.me SAML keys to decrypt auth responses (link to PR). ID.me has now "activated" the new certificate and our key rollover phase is complete. We no longer need this code.
Original issue(s)
department-of-veterans-affairs/va.gov-team#14221
Things to know about this PR
The settings.yml files have been updated to exclusively use the new key & new cert and do not need this code anymore: