move common internal/external exceptions to root dir #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindseySaari
changed the title
va-vfs-bot
temporarily deployed
to
10173-zeitwerk-lib-common-errors-namespacing/master
va-vfs-bot
temporarily deployed
to
10173-zeitwerk-lib-common-errors-namespacing/master
saneshark
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Zeitwerk mode uncovered many namespacing issues in relation to the vets-api codebase. In particular, many of our Common Exceptions were nested within (lib/common/exceptions/...) internal/external directories, but were missing the reference to ::Internal/::External within their namespacing across the codebase. It was decided in the original PR comment to move the exceptions to the root level directory and out of internal/external directories. Inheritance was suggested, but we may want to investigate at a later time as a tech debt item.
In a first attempt at this PR, we included the internal/external namespacing across the codebase, but this solution was decided upon as being optimal.
Original issue(s)
department-of-veterans-affairs/va.gov-team#10173
Original PR