Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a feature flag so the front end can use V1 #4378

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

darkbushido
Copy link
Contributor

Description of change

Creating a feature flag to tell the front end to use the facility locator API V1

Original issue(s)

department-of-veterans-affairs/va.gov-team#7658

Things to know about this PR

This just creates a feature flag for the front end.

@darkbushido darkbushido requested review from a team as code owners June 10, 2020 18:37
@darkbushido darkbushido requested a review from f1337 June 10, 2020 18:37
@va-vfs-bot va-vfs-bot temporarily deployed to add-feature-flag-facility_locator_fe_use_v1/master June 10, 2020 18:50 Inactive
@erluti
Copy link
Contributor

erluti commented Jun 10, 2020

Is there a matching front-end PR for featureFlagNames.js? (per this documentation https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/platform/tools/feature-toggles/#add-feature)

@va-vfs-bot va-vfs-bot temporarily deployed to add-feature-flag-facility_locator_fe_use_v1/master June 10, 2020 19:01 Inactive
@brangi
Copy link
Contributor

brangi commented Jun 10, 2020

Is there a matching front-end PR for featureFlagNames.js? (per this documentation https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/platform/tools/feature-toggles/#add-feature)

I did not think it was necessary to be added first, however, Will be added on this PR - department-of-veterans-affairs/vets-website@e211cad

Copy link
Contributor

@erluti erluti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkbushido darkbushido merged commit be28585 into master Jun 11, 2020
@darkbushido darkbushido deleted the add-feature-flag-facility_locator_fe_use_v1 branch June 11, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants