Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Prefill - config and yml changes to support FE form structure #4374

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

digitaldrk
Copy link
Contributor

@digitaldrk digitaldrk commented Jun 9, 2020

Description of change

This is a small adjustment to the prefill data structure associated with the 686c form. As that task evolves, so does the structure of the data.

Original issue(s)

https://app.zenhub.com/workspaces/vft-59c95ae5fda7577a9b3184f8/issues/department-of-veterans-affairs/va.gov-team/9222

Things to know about this PR

686c BE code is not quite ready. This just prefill data to help the veteran by populating info we already know about them.

From what I understand, there is no way to manually test if data is populating properly w/o going to staging, I've asked the engineer who initially implemented this to verify that's the case. Previous engineer responded. They relied on specs.

  • Are there Swagger docs that were updated?
    No
  • Is there any PII concerns or questions?
    No

Testing

Associated tests have been updated and are passing.

@va-vfs-bot va-vfs-bot temporarily deployed to dd-9222_fix_prefill_data_nesting_for_686/master June 9, 2020 16:31 Inactive
@digitaldrk digitaldrk marked this pull request as ready for review June 9, 2020 16:39
@digitaldrk digitaldrk requested review from a team as code owners June 9, 2020 16:39
@digitaldrk digitaldrk changed the title Adds config and yml changes to support FE form structure Form Prefill - config and yml changes to support FE form structure Jun 9, 2020
Copy link
Contributor

@thilton-oddball thilton-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kathleencrawford kathleencrawford added the VSA VSA Contract label Jun 9, 2020
@digitaldrk digitaldrk merged commit e4f84dc into master Jun 9, 2020
@digitaldrk digitaldrk deleted the dd-9222_fix_prefill_data_nesting_for_686 branch June 9, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VSA VSA Contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants