Add endpoint for EVSS #4370
Merged
Add endpoint for EVSS #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annaswims
force-pushed
the
aec/9735_intake_sites
branch
from
75ea1c6 to
fa105ea
Compare
annaswims
commented
Jun 10, 2020
| @@ -173,7 +173,6 @@ class ApidocsController < ApplicationController | |||
| Swagger::Schemas::ConnectedApplications, | |||
| Swagger::Schemas::Dependents, | |||
| Swagger::Schemas::DismissedStatus, | |||
| Swagger::Schemas::Form526::RatedDisabilities, | |||
Generated by 🚫 Danger |
7 tasks
annaswims
commented
Jun 11, 2020
| @@ -194,9 +195,6 @@ evss: | |||
| cert_path: ~ | |||
| key_path: ~ | |||
| root_ca: ~ | |||
| jwt: | |||
annaswims
commented
Jun 11, 2020
| @@ -444,10 +442,6 @@ betamocks: | |||
| cache_dir: /cache | |||
| services_config: config/betamocks/services_config.yml | |||
|
|
|||
| faraday_socks_proxy: | |||
There was a problem hiding this comment.
unused - TODO: check if I need to remove from devops repo.
erluti
reviewed
Jun 11, 2020
|
this pr will fix the EVSS connection in review instances https://github.com/department-of-veterans-affairs/devops/pull/7107 |
annaswims
commented
Jun 15, 2020
| @@ -517,6 +517,13 @@ | |||
| end | |||
| end | |||
|
|
|||
| it 'supports getting separation_locations' do | |||
| expect(subject).to validate(:get, '/v0/disability_compensation_form/separation_locations', 401) | |||
There was a problem hiding this comment.
@SarahJaine What I missed earlier when we were talking was the headers argument. The 401 response is unauthenticated.
SarahJaine
reviewed
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
For form526 BDD we need to add separation location, we can get that data from the EVSS reference data endpoint intakesites.
Previously, there were two other endpoints that were calling EVSS reference data endpoints through an old/unused authentication scheme so I stripped that out. That means we no longer need the sockisify gem.
Original issue
department-of-veterans-affairs/va.gov-team#9735
Things to know about this PR