Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include source_app label in StatsD #3645

Merged
merged 20 commits into from
Dec 26, 2019
Merged

include source_app label in StatsD #3645

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a59c042
include source_app label in StatsD
omgitsbillryan Dec 16, 2019
f8aa2cb
Merge branch 'master' into source_app_name
omgitsbillryan Dec 16, 2019
bd5e613
lint fixes
omgitsbillryan Dec 16, 2019
ffdb718
refactor to reduce cognitive complexity (for codeclimate)
omgitsbillryan Dec 16, 2019
ceb012e
more lint
omgitsbillryan Dec 16, 2019
da5f3cd
Merge branch 'master' into source_app_name
omgitsbillryan Dec 17, 2019
c50b59d
instructions to regenerate whitelist
omgitsbillryan Dec 17, 2019
890c39d
use script to update list
omgitsbillryan Dec 17, 2019
38e8c8f
Merge branch 'master' into source_app_name
omgitsbillryan Dec 17, 2019
0c83e15
log to sentry for unrecognized header vals
omgitsbillryan Dec 17, 2019
f7e7281
fixed bug, saved by a spec
omgitsbillryan Dec 17, 2019
729bca9
use Set instead of Array to be more performant
omgitsbillryan Dec 17, 2019
0e37e72
Merge branch 'master' into source_app_name
omgitsbillryan Dec 17, 2019
b7a80b5
small refactor + update whitelist regeneration instructions
omgitsbillryan Dec 19, 2019
142c4a2
Merge branch 'master' into source_app_name
omgitsbillryan Dec 19, 2019
b52cca5
remove sentry warning & use empty string instead of omitting entire l…
omgitsbillryan Dec 20, 2019
3409cac
Merge branch 'master' into source_app_name
omgitsbillryan Dec 20, 2019
02ccd3a
Merge branch 'master' into source_app_name
omgitsbillryan Dec 20, 2019
ef839ce
Merge branch 'master' into source_app_name
omgitsbillryan Dec 23, 2019
2e46312
Merge branch 'master' into source_app_name
omgitsbillryan Dec 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use script to update list
  • Loading branch information
@omgitsbillryan
omgitsbillryan committed Dec 17, 2019
commit 890c39dc7ee41b6b9b3082b9bcfe99259561d2d5
5 changes: 3 additions & 2 deletions lib/statsd_middleware.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ class StatsdMiddleware
SOURCE_APP_NAMES = %w[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we intend for FE engineers to know to keep this list up to date? Can you add a comment, so people in the future know that this should be kept up to date manually and FE engineers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Some thoughts and stuff:

  • added logic to warn to sentry when an unrecognized Source-App-Name header comes in
  • add instructional comment on how to regenerate
  • if we're out of date on the whitelist it isnt that big of a deal, it will result in some small holes in our metrics

0993-edu-benefits
0994-edu-benefits
0996-higher-level-review
1990-edu-benefits
1990e-edu-benefits
1990n-edu-benefits
1995-STEM-edu-benefits
1995-edu-benefits
526EZ-all-claims
526EZ-claims-increase
Expand All @@ -38,6 +38,8 @@ class StatsdMiddleware
claims-status
connected-accounts
dashboard
dependents-view-dependents
disability-my-rated-disabilities
discharge-upgrade-instructions
facilities
feedback-tool
Expand All @@ -50,7 +52,6 @@ class StatsdMiddleware
post-911-gib-status
pre-need
profile-360
profile-360-beta
proxy-rewrite
public-outreach-materials
search
Expand Down