Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop fixing offenses related to rubocop upgrade #3319

Merged
merged 24 commits into from
Sep 19, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6490bcf
Fixing Rubocop Layout/ClosingHeredocIndentation offenses.
thilton-oddball Sep 19, 2019
c6fb9cb
Fixing Rubocop Layout/ClosingParenthesisIndentation offenses.
thilton-oddball Sep 19, 2019
561cc31
Fixing Rubocop Layout/EmptyComment offenses.
thilton-oddball Sep 19, 2019
d5683d8
Fixing Rubocop Layout/EmptyLinesAroundBlockBody offenses.
thilton-oddball Sep 19, 2019
cf14f75
Fixing Rubocop Layout/IndentationWidth offenses.
thilton-oddball Sep 19, 2019
cc7c73f
Fixing Rubocop Layout/LeadingBlankLines offenses.
thilton-oddball Sep 19, 2019
01fd7b9
Fixing Rubocop Layout/RescueEnsureAlignment offenses.
thilton-oddball Sep 19, 2019
0286a6a
Fixing Rubocop Layout/SpaceAroundOperators offenses.
thilton-oddball Sep 19, 2019
35d7a8b
Fixing Rubocop Lint/BigDecimalNew offenses.
thilton-oddball Sep 19, 2019
7197af0
Fixing Rubocop Lint/SafeNavigationConsistency offenses.
thilton-oddball Sep 19, 2019
16b9fd7
Fixing Rubocop Lint/UnneededCopDisableDirective offenses.
thilton-oddball Sep 19, 2019
07c873f
Fixing Rubocop Lint/UnneededCopEnableDirective offenses.
thilton-oddball Sep 19, 2019
4dc7f23
Fixing Rubocop Rails/HttpStatus offenses.
thilton-oddball Sep 19, 2019
bd15fe3
Fixing Rubocop Style/ExpandPathArguments offenses.
thilton-oddball Sep 19, 2019
0443e02
Fixing Rubocop Style/MutableConstant offenses.
thilton-oddball Sep 19, 2019
69e8b85
Fixing Rubocop Style/TrailingCommaInArrayLiteral offenses.
thilton-oddball Sep 19, 2019
9e96c57
Fixing Rubocop Style/TrailingCommaInHashLiteral offenses.
thilton-oddball Sep 19, 2019
efaa9c7
Fixing Rubocop Style/UnneededCondition offenses.
thilton-oddball Sep 19, 2019
14bfd57
Fixing Rubocop Style/UnneededSort offenses.
thilton-oddball Sep 19, 2019
62b8c1f
Fixing Rubocop Style/WordArray offenses.
thilton-oddball Sep 19, 2019
2187110
removing commented out TODOs in .rubocop_todo.yml
thilton-oddball Sep 19, 2019
ceacdd7
merging in master
thilton-oddball Sep 19, 2019
50059b1
Fixing Rubocop Style/WordArray offenses.
thilton-oddball Sep 19, 2019
4aca339
Merge branch 'master' into tjh-rubocop-fixing-offenses
annaswims Sep 19, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing Rubocop Layout/IndentationWidth offenses.
  • Loading branch information
thilton-oddball committed Sep 19, 2019
commit cf14f75dd5ee02fdf73f5e02f074e9835aa14006
6 changes: 3 additions & 3 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ Layout/EmptyLineAfterGuardClause:
# Offense count: 8
# Cop supports --auto-correct.
# Configuration parameters: Width, IgnoredPatterns.
Layout/IndentationWidth:
Exclude:
- 'lib/facilities/vba_facility.rb'
# Layout/IndentationWidth:
# Exclude:
# - 'lib/facilities/vba_facility.rb'

# Offense count: 4
# Cop supports --auto-correct.
Expand Down
126 changes: 63 additions & 63 deletions lib/facilities/vba_facility.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,76 +3,76 @@
module Facilities
class VBAFacility < BaseFacility
class << self
attr_writer :validate_on_load
attr_writer :validate_on_load

def pull_source_data
metadata = Facilities::MetadataClient.new.get_metadata(arcgis_type)
max_record_count = metadata['maxRecordCount']
Facilities::Client.new.get_all_facilities(arcgis_type, sort_field, max_record_count).map(&method(:new))
end
def pull_source_data
metadata = Facilities::MetadataClient.new.get_metadata(arcgis_type)
max_record_count = metadata['maxRecordCount']
Facilities::Client.new.get_all_facilities(arcgis_type, sort_field, max_record_count).map(&method(:new))
end

def service_list
%w[ApplyingForBenefits BurialClaimAssistance DisabilityClaimAssistance
eBenefitsRegistrationAssistance EducationAndCareerCounseling EducationClaimAssistance
FamilyMemberClaimAssistance HomelessAssistance VAHomeLoanAssistance Pensions
InsuranceClaimAssistanceAndFinancialCounseling PreDischargeClaimAssistance
IntegratedDisabilityEvaluationSystemAssistance TransitionAssistance
VocationalRehabilitationAndEmploymentAssistance UpdatingDirectDepositInformation]
end
def service_list
%w[ApplyingForBenefits BurialClaimAssistance DisabilityClaimAssistance
eBenefitsRegistrationAssistance EducationAndCareerCounseling EducationClaimAssistance
FamilyMemberClaimAssistance HomelessAssistance VAHomeLoanAssistance Pensions
InsuranceClaimAssistanceAndFinancialCounseling PreDischargeClaimAssistance
IntegratedDisabilityEvaluationSystemAssistance TransitionAssistance
VocationalRehabilitationAndEmploymentAssistance UpdatingDirectDepositInformation]
end

def arcgis_type
'VBA_Facilities'
end
def arcgis_type
'VBA_Facilities'
end

def sort_field
'Facility_Number'
end
def sort_field
'Facility_Number'
end

def attribute_map
{
'unique_id' => 'Facility_Number',
'name' => 'Facility_Name',
'classification' => 'Facility_Type',
'website' => 'Website_URL',
'phone' => { 'main' => 'Phone', 'fax' => 'Fax' },
'physical' => { 'address_1' => 'Address_1', 'address_2' => 'Address_2',
'address_3' => '', 'city' => 'City', 'state' => 'State',
'zip' => 'Zip' },
'hours' => BaseFacility::HOURS_STANDARD_MAP,
'benefits' => benefits_mapping,
'mapped_fields' => mapped_fields_list
}
end
def attribute_map
{
'unique_id' => 'Facility_Number',
'name' => 'Facility_Name',
'classification' => 'Facility_Type',
'website' => 'Website_URL',
'phone' => { 'main' => 'Phone', 'fax' => 'Fax' },
'physical' => { 'address_1' => 'Address_1', 'address_2' => 'Address_2',
'address_3' => '', 'city' => 'City', 'state' => 'State',
'zip' => 'Zip' },
'hours' => BaseFacility::HOURS_STANDARD_MAP,
'benefits' => benefits_mapping,
'mapped_fields' => mapped_fields_list
}
end

def benefits_mapping
{
'ApplyingForBenefits' => 'Applying_for_Benefits',
'BurialClaimAssistance' => 'Burial_Claim_assistance',
'DisabilityClaimAssistance' => 'Disability_Claim_assistance',
'eBenefitsRegistrationAssistance' => 'eBenefits_Registration',
'EducationAndCareerCounseling' => 'Education_and_Career_Counseling',
'EducationClaimAssistance' => 'Education_Claim_Assistance',
'FamilyMemberClaimAssistance' => 'Family_Member_Claim_Assistance',
'HomelessAssistance' => 'Homeless_Assistance',
'VAHomeLoanAssistance' => 'VA_Home_Loan_Assistance',
'InsuranceClaimAssistanceAndFinancialCounseling' => 'Insurance_Claim_Assistance',
'IntegratedDisabilityEvaluationSystemAssistance' => 'IDES',
'PreDischargeClaimAssistance' => 'Pre_Discharge_Claim_Assistance',
'TransitionAssistance' => 'Transition_Assistance',
'UpdatingDirectDepositInformation' => 'Updating_Direct_Deposit_Informa',
'VocationalRehabilitationAndEmploymentAssistance' => 'Vocational_Rehabilitation_Emplo'
}
end
def benefits_mapping
{
'ApplyingForBenefits' => 'Applying_for_Benefits',
'BurialClaimAssistance' => 'Burial_Claim_assistance',
'DisabilityClaimAssistance' => 'Disability_Claim_assistance',
'eBenefitsRegistrationAssistance' => 'eBenefits_Registration',
'EducationAndCareerCounseling' => 'Education_and_Career_Counseling',
'EducationClaimAssistance' => 'Education_Claim_Assistance',
'FamilyMemberClaimAssistance' => 'Family_Member_Claim_Assistance',
'HomelessAssistance' => 'Homeless_Assistance',
'VAHomeLoanAssistance' => 'VA_Home_Loan_Assistance',
'InsuranceClaimAssistanceAndFinancialCounseling' => 'Insurance_Claim_Assistance',
'IntegratedDisabilityEvaluationSystemAssistance' => 'IDES',
'PreDischargeClaimAssistance' => 'Pre_Discharge_Claim_Assistance',
'TransitionAssistance' => 'Transition_Assistance',
'UpdatingDirectDepositInformation' => 'Updating_Direct_Deposit_Informa',
'VocationalRehabilitationAndEmploymentAssistance' => 'Vocational_Rehabilitation_Emplo'
}
end

def mapped_fields_list
%w[Facility_Number Facility_Name Facility_Type Website_URL Lat Long Other_Services
Address_1 Address_2 City State Zip Phone Fax Monday Tuesday Wednesday Thursday
Friday Saturday Sunday Applying_for_Benefits Burial_Claim_assistance
Disability_Claim_assistance eBenefits_Registration Education_and_Career_Counseling
Education_Claim_Assistance Family_Member_Claim_Assistance Homeless_Assistance
VA_Home_Loan_Assistance Insurance_Claim_Assistance IDES Pre_Discharge_Claim_Assistance
Transition_Assistance Updating_Direct_Deposit_Informa Vocational_Rehabilitation_Emplo]
end
def mapped_fields_list
%w[Facility_Number Facility_Name Facility_Type Website_URL Lat Long Other_Services
Address_1 Address_2 City State Zip Phone Fax Monday Tuesday Wednesday Thursday
Friday Saturday Sunday Applying_for_Benefits Burial_Claim_assistance
Disability_Claim_assistance eBenefits_Registration Education_and_Career_Counseling
Education_Claim_Assistance Family_Member_Claim_Assistance Homeless_Assistance
VA_Home_Loan_Assistance Insurance_Claim_Assistance IDES Pre_Discharge_Claim_Assistance
Transition_Assistance Updating_Direct_Deposit_Informa Vocational_Rehabilitation_Emplo]
end
end
end
end