Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VANotify] Remove va_notify_metadata_statsd_tags flipper toggle #20729

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Feb 11, 2025

Summary

  • This work is behind a feature toggle (flipper): NO
  • Deleting the va_notify_metadata_statsd_tags toggle from the features file. The logic that uses it will be removed before merging this.
  • I will delete the toggle from the environment databases per the platform docs as part of this work
  • 1010 Health Apps

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to coope93-remove-va-notify-statsd-tags-flipper/main/main February 11, 2025 14:16 Inactive
Copy link

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:

@va-vfs-bot va-vfs-bot temporarily deployed to coope93-remove-va-notify-statsd-tags-flipper/main/main February 11, 2025 14:35 Inactive
@coope93 coope93 changed the title remove va_notify_metadata_statsd_tags flipper toggle [VANotify] Remove va_notify_metadata_statsd_tags flipper toggle Feb 11, 2025
@coope93 coope93 self-assigned this Feb 11, 2025
Base automatically changed from coope93-remove-va-notify-statsd-tags-toggle to master February 21, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants