-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARP allowlist] Create VA accredited individuals allow-list table #20514
Conversation
ar_user_account_accredited_individuals
to track authorized VSO representatives - Stores registration numbers, POA holder types, and user account info - Uses UUID for primary key 2. Adds indexes to support: - Unique registration numbers - CSV-based allow-list synchronization (composite unique index) - POA holder type constraints per email ## Why - Maintains authoritative allow-list of accredited VSO representatives - Supports automated synchronization with source CSV allow-list - Ensures data integrity through uniqueness constraints - Provides foundation for POA request authorization ## Testing - Ran migrations in development - Verified all uniqueness constraints - Tested with sample representative dataThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will platform ask for?
disable_ddl_transaction!
algorithm: :concurrently
add_index :ar_user_account_accredited_individuals, | ||
:accredited_individual_registration_number, | ||
unique: true | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will platform ask for?
disable_ddl_transaction!
algorithm: :concurrently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 😄
And please include this index update in a separate migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ojbucao here are the docs explaining that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmtolmach Rebecca. Would you be able to review again? Thanks so much!🙏
6d00196
to
ce3475b
Compare
ce3475b
to
802f67e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tag me if you need a re-review. I'm thinking you might have a merge conflict after you merge your other PR that modifies the schema. 😄
697397a
to
208bbad
Compare
Hi hi. @rmtolmach I fixed the conflict.🙏 |
Creates ar_user_account_accredited_individuals table and supporting indexes to maintain an allow-list of VA representatives authorized to handle Power of Attorney requests. Includes unique constraints on registration numbers and composite fields to support synchronization with source allow-list CSV.
208bbad
to
90d63ad
Compare
This PR sets up the database structure to maintain an allow-list of accredited VA representatives who can handle Power of Attorney requests.
department-of-veterans-affairs/va.gov-team#99863
Changes
ar_user_account_accredited_individuals
to track authorized VSO representativesWhy
Testing