Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARP allowlist] Create VA accredited individuals allow-list table #20514

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

ojbucao
Copy link
Contributor

@ojbucao ojbucao commented Jan 28, 2025

This PR sets up the database structure to maintain an allow-list of accredited VA representatives who can handle Power of Attorney requests.

department-of-veterans-affairs/va.gov-team#99863

Changes

  1. Creates new allow-list table ar_user_account_accredited_individuals to track authorized VSO representatives
    • Stores registration numbers, POA holder types, and user account info
    • Uses UUID for primary key
  2. Adds indexes to support:
    • Unique registration numbers
    • CSV-based allow-list synchronization (composite unique index)
    • POA holder type constraints per email

Why

  • Maintains authoritative allow-list of accredited VSO representatives
  • Supports automated synchronization with source CSV allow-list
  • Ensures data integrity through uniqueness constraints
  • Provides foundation for POA request authorization

Testing

  • Ran migrations in development
  • Verified all uniqueness constraints
  • Tested with sample representative data

@ojbucao ojbucao changed the title This PR sets up the database structure to maintain an allow-list of accredited VA representatives who can handle Power of Attorney requests. ## Changes 1. Creates new allow-list table ar_user_account_accredited_individuals to track authorized VSO representatives - Stores registration numbers, POA holder types, and user account info - Uses UUID for primary key 2. Adds indexes to support: - Unique registration numbers - CSV-based allow-list synchronization (composite unique index) - POA holder type constraints per email ## Why - Maintains authoritative allow-list of accredited VSO representatives - Supports automated synchronization with source CSV allow-list - Ensures data integrity through uniqueness constraints - Provides foundation for POA request authorization ## Testing - Ran migrations in development - Verified all uniqueness constraints - Tested with sample representative data Create VA accredited individuals allow-list table Jan 28, 2025
@ojbucao ojbucao marked this pull request as ready for review January 29, 2025 00:05
@ojbucao ojbucao requested review from a team as code owners January 29, 2025 00:05
@ojbucao ojbucao marked this pull request as draft January 29, 2025 00:06
@ojbucao ojbucao requested review from nihil2501 and chumpy January 29, 2025 00:06
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/allow-list-migrations/main/main January 29, 2025 01:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/allow-list-migrations/main/main January 30, 2025 23:04 Inactive
nihil2501
nihil2501 previously approved these changes Feb 3, 2025
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will platform ask for?

  • disable_ddl_transaction!
  • algorithm: :concurrently

Comment on lines 10 to 13
add_index :ar_user_account_accredited_individuals,
:accredited_individual_registration_number,
unique: true
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will platform ask for?

  • disable_ddl_transaction!
  • algorithm: :concurrently

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 😄
And please include this index update in a separate migration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojbucao here are the docs explaining that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmtolmach Rebecca. Would you be able to review again? Thanks so much!🙏

chumpy
chumpy previously approved these changes Feb 3, 2025
@nihil2501 nihil2501 changed the title Create VA accredited individuals allow-list table [ARP allowlist] Create VA accredited individuals allow-list table Feb 3, 2025
@ojbucao ojbucao marked this pull request as ready for review February 4, 2025 00:02
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/allow-list-migrations/main/main February 4, 2025 06:05 Inactive
@ojbucao ojbucao dismissed stale reviews from chumpy and nihil2501 via ce3475b February 4, 2025 17:55
@ojbucao ojbucao force-pushed the art/poa-requests/allow-list-migrations branch from 6d00196 to ce3475b Compare February 4, 2025 17:55
@ojbucao ojbucao requested a review from rmtolmach February 4, 2025 17:58
@ojbucao ojbucao force-pushed the art/poa-requests/allow-list-migrations branch from ce3475b to 802f67e Compare February 4, 2025 17:58
@ojbucao ojbucao requested a review from nihil2501 February 4, 2025 18:25
rmtolmach
rmtolmach previously approved these changes Feb 4, 2025
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag me if you need a re-review. I'm thinking you might have a merge conflict after you merge your other PR that modifies the schema. 😄

@rmtolmach rmtolmach requested a review from a team February 4, 2025 20:06
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/allow-list-migrations/main/main February 4, 2025 20:18 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/allow-list-migrations branch from 697397a to 208bbad Compare February 4, 2025 20:20
@ojbucao ojbucao requested a review from rmtolmach February 4, 2025 20:20
@ojbucao
Copy link
Contributor Author

ojbucao commented Feb 4, 2025

Tag me if you need a re-review. I'm thinking you might have a merge conflict after you merge your other PR that modifies the schema. 😄

Hi hi. @rmtolmach I fixed the conflict.🙏

@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/allow-list-migrations/main/main February 4, 2025 20:33 Inactive
Creates ar_user_account_accredited_individuals table and supporting
indexes to maintain an allow-list of VA representatives authorized to
handle Power of Attorney requests. Includes unique constraints on
registration numbers and composite fields to support synchronization
with source allow-list CSV.
@ojbucao ojbucao force-pushed the art/poa-requests/allow-list-migrations branch from 208bbad to 90d63ad Compare February 4, 2025 20:43
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/allow-list-migrations/main/main February 4, 2025 20:45 Inactive
@ojbucao ojbucao merged commit c00636f into master Feb 4, 2025
22 checks passed
@ojbucao ojbucao deleted the art/poa-requests/allow-list-migrations branch February 4, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants