Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent to file (#103121) #20428

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

pixiitech
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES/NO Yes
  • (Summarize the changes that have been made to the platform)
    Added endpoints to ARP portal to view and submit Intent to File requests
  • (If bug, how to reproduce) feature
  • (What is the solution, why is this the solution?) So that authorized reps can submit an intent to file on behalf of the vet/claimant
  • (Which team do you work for, does your team own the maintenance of this component?) ARF/ART
  • (If introducing a flipper, what is the success criteria being targeted?) existing flipper

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  • 101321
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to art/intent-to-file/endpoints/main/main January 23, 2025 22:24 Inactive
@pixiitech pixiitech force-pushed the art/intent-to-file/endpoints branch from 8dd34f3 to bec1b98 Compare January 24, 2025 17:10
@va-vfs-bot va-vfs-bot temporarily deployed to art/intent-to-file/endpoints/main/main January 24, 2025 17:38 Inactive
@pixiitech pixiitech force-pushed the art/intent-to-file/endpoints branch from bec1b98 to d96642a Compare January 24, 2025 19:43
@va-vfs-bot va-vfs-bot temporarily deployed to art/intent-to-file/endpoints/main/main January 24, 2025 19:58 Inactive
@pixiitech pixiitech force-pushed the art/intent-to-file/endpoints branch from d96642a to 8e663a7 Compare January 27, 2025 16:14
@va-vfs-bot va-vfs-bot temporarily deployed to art/intent-to-file/endpoints/main/main January 27, 2025 16:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants