Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEBT 1091 - Rename vawave files to end in 3 digit numbers #20370

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

alexchan-va
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): YES/NO no
  • (Summarize the changes that have been made to the platform) Standardized the naming of the vawave file so that it always ends in 3 digits
  • (If bug, how to reproduce) n/a
  • (What is the solution, why is this the solution?) Change string formatting
  • (Which team do you work for, does your team own the maintenance of this component?) VEBT
  • (If introducing a flipper, what is the success criteria being targeted?) n/a

Related issue(s)

Testing done

  • [x ] New code is covered by unit tests
  • Describe what the old behavior was prior to the change It only made files without 0 padding (i.e. vawave1 vs vawave001)
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing Check S3 buckets to confirm correct naming
  • If this work is behind a flipper: n/a

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas) none

Acceptance criteria

  • [x ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [x ] No error nor warning in the console.
  • [x ] Events are being sent to the appropriate logging solution
  • [x ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@@ -24,7 +24,7 @@ def address_changes_filename = prefixed_dated('CHGADD')
def direct_deposit_filename = prefixed_dated('DirDep')

# enrollment verification sent to BDN everyday.
def verification_filename = "vawave#{now_in_bdn_timezone.yday}"
def verification_filename = format('vawave%03d', now_in_bdn_timezone.yday)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen this before, but that's pretty cool

@alexchan-va alexchan-va merged commit be07266 into master Jan 21, 2025
36 of 37 checks passed
@alexchan-va alexchan-va deleted the vebt-1091 branch January 21, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants