Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Metrics/MethodLength disable on V0::ClaimDocumentsController #20345

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Refactor Metrics/MethodLength disable on V0::ClaimDocumentsController #20345

merged 2 commits into from
Jan 22, 2025

Conversation

stevenjcumming
Copy link
Contributor

@stevenjcumming stevenjcumming commented Jan 17, 2025 •
edited
Loading

Summary

  • Refactor stamped_pdf_valid? to fix Metrics/MethodLength cop

Related issue(s)

  • n/a

Testing done

  • n/a

Acceptance criteria

  • Rubocop disable is removed

@stevenjcumming stevenjcumming requested review from a team as code owners January 17, 2025 12:57
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-mld-claim-doc-controller/main/main January 17, 2025 13:12 Inactive
@stevenjcumming stevenjcumming marked this pull request as draft January 17, 2025 13:24
@stevenjcumming stevenjcumming self-assigned this Jan 17, 2025
@stevenjcumming stevenjcumming marked this pull request as ready for review January 17, 2025 13:37
@stevenjcumming
Copy link
Contributor Author

@kylesoskin could you review this refactor PR?

kylesoskin
kylesoskin approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@kylesoskin kylesoskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, looks like it is just moving code out to functions to get rid of the rubocop disabling... which is good

@stevenjcumming stevenjcumming merged commit d4487bf into master Jan 22, 2025
25 of 26 checks passed
@stevenjcumming stevenjcumming deleted the sjc-mld-claim-doc-controller branch January 22, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylesoskin kylesoskin kylesoskin approved these changes

Assignees

@stevenjcumming stevenjcumming

Labels
ready-for-backend-review require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjcumming @kylesoskin @va-vfs-bot