-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
98887 Callback implementation for IVC emails - IVC CHAMPVA forms #20334
Merged
michaelclement
merged 9 commits into
master
from
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify
Jan 21, 2025
Merged
98887 Callback implementation for IVC emails - IVC CHAMPVA forms #20334
michaelclement
merged 9 commits into
master
from
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
va-vfs-bot
temporarily deployed
to
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify/main/main
January 16, 2025 21:51
Inactive
va-vfs-bot
temporarily deployed
to
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify/main/main
January 17, 2025 16:11
Inactive
va-vfs-bot
temporarily deployed
to
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify/main/main
January 17, 2025 16:20
Inactive
va-vfs-bot
temporarily deployed
to
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify/main/main
January 17, 2025 16:29
Inactive
reiting
previously approved these changes
Jan 17, 2025
@michaelclement there's a failing test |
va-vfs-bot
temporarily deployed
to
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify/main/main
January 17, 2025 18:58
Inactive
…onfirmation-emails-sent-by-va-notify
va-vfs-bot
temporarily deployed
to
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify/main/main
January 17, 2025 20:30
Inactive
…onfirmation-emails-sent-by-va-notify
reiting
approved these changes
Jan 21, 2025
stevenjcumming
approved these changes
Jan 21, 2025
michaelclement
deleted the
98887-callback-implementation-to-monitor-confirmation-emails-sent-by-va-notify
branch
January 21, 2025 15:04
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a custom callback class for use with IVC emails sent through VA Notify. The main purpose of the callback is to improve our Data Dog displays of emails being sent so we can monitor successful/failed deliveries and how many emails are sent per form.
This PR is part of an ongoing effort. To fully test this callback, the callback class needs to be merged into staging. I've added a feature flag so this can be safely tested without impacting production.
Related issue(s)
Testing done
track_email_sent
invoked. However, to verify the VA Notify integration the code has to be fully merged into staging so that whichever node receives the VA Notify callback will have the latest code.Screenshots
NA
What areas of the site does it impact?
IVC CHAMPVA forms
Acceptance criteria
Requested Feedback
NA