CC Referral Appointments - Draft Appointment Submit #20323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
devin-mccurdy
force-pushed
the
98251_draft_appointment_submit
branch
from
97208ba to
eeb109a
Compare
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
github-actions
bot
added
test-failure
test-passing
and removed
test-passing
test-failure
labels
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
github-actions
bot
added
require-backend-approval
test-failure
and removed
test-passing
labels
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
|
@devin-mccurdy this PR has a failing test |
Whoops, last minute update to match the draft serializer PR and missed that I'd also need to update that test |
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
stevenjcumming
previously approved these changes
Jan 28, 2025
devin-mccurdy
dismissed stale reviews from stevenjcumming and randomsync
via
f6a2309
devin-mccurdy
force-pushed
the
98251_draft_appointment_submit
branch
from
e2ddc57 to
f6a2309
Compare
stevenjcumming
requested changes
Jan 28, 2025
Comment on lines
-448
to
-451
|
|
||
| vaos: | ||
| eps: | ||
| key_path: modules/health_quest/config/rsa/sandbox_rsa |
There was a problem hiding this comment.
I just approved a PR that added this. Please confirm this deletion
There was a problem hiding this comment.
there were 2 PRs that were merged that both included this change in different places of the test.yml, which caused this to be duped in final merge
There was a problem hiding this comment.
Yes, this is correct - it also got added and merged in another PR and this is removing one of them
| @@ -26,4 +26,52 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe '#build_patient_attributes' do | |||
There was a problem hiding this comment.
2 small things:
- the describe method should match the name exactly
#patient_attributes - you don't need to test private methods. I would encourage you to consider removing this because it make refactoring difficult.
va-vfs-bot
temporarily deployed
to
98251_draft_appointment_submit/main/main
stevenjcumming
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This work is behind a feature toggle (flipper): NO - this is a new endpoint and not behind a backend feature flag.
Add a new route to the VAOS module that submits CC referral draft appointments to EPS. The submission doesn't return any useful data other than the
201response.Related issue(s)
Testing done
Screenshots
N/A
What areas of the site does it impact?
VAOS module
Acceptance criteria