replace Rails logging with StatsD metrics for diagnostic codes

[asiisii]

Summary

• This work is behind a feature toggle (flipper): NO
• Replaced Rails.logger.info calls in log_hyphenated_diagnostic_codes with StatsD.increment to avoid logging sensitive diagnostic codes. The new metrics include diagnostic code, diagnostic code type, and hyphenated diagnostic code as tags.
• This change improves privacy by preventing potential de-anonymization of veterans based on logged diagnostic codes.

Related issue(s)

• #3941

Testing done

• New code is covered by unit tests.
• Previously, diagnostic codes were logged using Rails.logger.info.
• Verified that StatsD.increment is now used to record metrics, and updated tests to ensure that the correct metrics and tags are being sent.

What areas of the site does it impact?

• This change impacts the log_hyphenated_diagnostic_codes method in the MaxRatingAnnotator class, which handles processing diagnostic codes for rated disabilities.

Acceptance criteria

• I updated unit tests to verify the new StatsD.increment calls.
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution (StatsD).
• Documentation has been updated (link to documentation, if any).
• No sensitive information (i.e., PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs.

[dfitchett]

LGTM! 🚀

[nanotone]

👍