Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded vets_json_schema to 24.7.4 #20265

Closed
wants to merge 2 commits into from

Conversation

RachalCassity
Copy link
Member

@RachalCassity RachalCassity commented Jan 14, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

PCIU variables appropriately renamed in the new vets-json-schema version. Vets-Website PCIU variables are imported from the hardcoded PCIU Vets-Json-schema variables. Vets-website and vets-json-schema pull requests have been merged.

Related issue(s)

Testing done

  • New code is covered by unit tests

Contact Information for a test user was tested locally with the new schema version.

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@RachalCassity RachalCassity requested a review from a team as a code owner January 14, 2025 16:51
Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a PR here that also updates the 0969 fixtures, but if this makes it in first I can rebase.

@RachalCassity
Copy link
Member Author

There's a PR here that also updates the 0969 fixtures, but if this makes it in first I can rebase.

Perfect!!

@RachalCassity
Copy link
Member Author

This pull request was replaced with another pr and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants