Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99356: Reduce frequency of DR SavedClaim status updater jobs #20241

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

dfong-adh
Copy link
Contributor

@dfong-adh dfong-adh commented Jan 11, 2025

Summary

This PR changes the frequency and offset of the SavedClaim status updater jobs to reduce the number of requests to the LH API.

  • This work is behind a feature toggle (flipper): NO

Related issue(s)

department-of-veterans-affairs/va.gov-team#99356

Testing done

Tested locally.

  • New code is covered by unit tests - only updates the periodic job schedule
    The old behavior was to run all status updater jobs hourly - this decreases the frequency of each job to 6 times a day.

What areas of the site does it impact?

Sidekiq jobs to update the SavedClaim table

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

kayline
kayline previously approved these changes Jan 13, 2025
Copy link
Contributor

@kayline kayline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dfong-adh dfong-adh marked this pull request as ready for review January 13, 2025 20:07
@dfong-adh dfong-adh requested review from a team as code owners January 13, 2025 20:07
lib/periodic_jobs.rb Outdated Show resolved Hide resolved
@dfong-adh dfong-adh merged commit b8d7d9a into master Jan 16, 2025
22 checks passed
@dfong-adh dfong-adh deleted the 99356-status-updater-jobs-frequency branch January 16, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants