Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

98411: Add feature flag for burial module #20144

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

balexandr
Copy link
Contributor

@balexandr balexandr commented Jan 7, 2025

Add burial feature flipper

Summary

  • Add flipper to feature.yml

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to 98411-create-burial-flipper/main/main January 7, 2025 22:26 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98411-create-burial-flipper/main/main January 7, 2025 22:53 Inactive
Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaiWilkin TaiWilkin marked this pull request as ready for review January 8, 2025 14:25
@TaiWilkin TaiWilkin requested review from a team as code owners January 8, 2025 14:25
@balexandr balexandr enabled auto-merge (squash) January 8, 2025 15:32
@balexandr balexandr merged commit 91ceac0 into master Jan 8, 2025
21 checks passed
@balexandr balexandr deleted the 98411-create-burial-flipper branch January 8, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants