Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burial 100122 Correct log level for FormSubmissionAttempt Status Change #20143

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

wayne-weibel
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

correct log level

Related issue(s)

Burial | fix log level for FormSubmissionAttempt failure and add monitor in datadog

Testing done

  • New code is covered by unit tests
  • failure would log at 'info'
  • failure not logs at 'error' and manual logs at 'warn'

What areas of the site does it impact?

any team observing logs for FormSubmissionAttempt

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@wayne-weibel wayne-weibel added the burial-benefits Label used for Pull Requests that impact Burial claims (530) label Jan 7, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to burial-100122-formsubmissionattempt-log-level/main/main January 7, 2025 21:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to burial-100122-formsubmissionattempt-log-level/main/main January 7, 2025 22:08 Inactive
balexandr
balexandr previously approved these changes Jan 7, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to burial-100122-formsubmissionattempt-log-level/main/main January 8, 2025 14:48 Inactive
@wayne-weibel wayne-weibel merged commit 2066891 into master Jan 14, 2025
30 of 31 checks passed
@wayne-weibel wayne-weibel deleted the burial-100122-formsubmissionattempt-log-level branch January 14, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
burial-benefits Label used for Pull Requests that impact Burial claims (530) require-backend-approval test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants