Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multistamp logger and atomic move #20139

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rubocop indent
  • Loading branch information
cloudmagic80 committed Jan 9, 2025
commit ee29a7fd8df36b41101faa8dc7ef8211087eccfc
6 changes: 3 additions & 3 deletions modules/ivc_champva/app/services/ivc_champva/pdf_stamper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
end
end

# rubocop:disable metrics/method_length
# rubocop:disable metrics/method_length, mismatched indentation
def self.perform_multistamp(stamped_template_path, stamp_path)
out_path = "#{Common::FileHelpers.random_file_path}.pdf"
pdftk = PdfFill::Filler::PDF_FORMS
Expand Down Expand Up @@ -128,12 +128,12 @@
pdftk.multistamp(stamped_template_path, stamp_path, out_path)
File.delete(stamped_template_path)
File.rename(out_path, stamped_template_path)
rescue
rescue

Check failure on line 131 in modules/ivc_champva/app/services/ivc_champva/pdf_stamper.rb

View workflow job for this annotation

GitHub Actions / Linting and Security

Lint/Syntax: unexpected token kRESCUE (Using Ruby 3.3 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
Common::FileHelpers.delete_file_if_exists(out_path)
raise
end
end
# rubocop:enable metrics/method_length
# rubocop:enable metrics/method_length, mismatched indentation

def self.stamp_submission_date(stamped_template_path, desired_stamps)
if desired_stamps.is_a?(Array)
Expand Down
Loading