Add pagination info to Vets::Collection

[stevenjcumming]

Mergers to a feature branch

Summary

• Add new paginate method to collection clas
• Create a new class Pagination to handle pagination details and record shifting

Related issue(s)

• main PR: Create Vets::Collection #19895
• Create Vets::Collection with primary Common::Collection functionality va.gov-team#99123

Testing done

• Manual testing
• New spec for module

Acceptance criteria

• Collections of Vets::Models can paginate
• WillPagination::Collection can paginate
• Pagination functionality has the same default as Common::Collection

[github-actions]

1 Warning

⚠️

This PR changes 270 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files lib/vets/collection.rb (+32/-1) lib/vets/collections/pagination.rb (+41/-0) spec/lib/vets/collection_spec.rb (+134/-15) spec/lib/vets/collections/pagination_spec.rb (+47/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:

[LindseySaari]

Shouldn't the raise ArgumentError logic here be the inverse?

unless records_will_paginate_collection

[stevenjcumming]

Yes, thank you!

[stevenjcumming]

@LindseySaari I fixed the error you found and I also added a test

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:

[LindseySaari]

@stevenjcumming Do you plan to merge this into master or your other base branch? I see CODEOWNERS is failing but I think that's ok if you're not merging into master. It seems it's having issue with comparing to a feature branch

[stevenjcumming]

@stevenjcumming Do you plan to merge this into master or your other base branch? I see CODEOWNERS is failing but I think that's ok if you're not merging into master. It seems it's having issue with comparing to a feature branch

I'm just merging it into the collection feature branch. I thought it would be easier to separate the PRs like this before merging them into master.