Log whenever Form Upload Flow prefill data is changed #20030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
log-when-form-upload-prefill-is-changed/main/main
va-vfs-bot
temporarily deployed
to
log-when-form-upload-prefill-is-changed/main/main
va-vfs-bot
temporarily deployed
to
log-when-form-upload-prefill-is-changed/main/main
github-actions
bot
added
test-passing
ready-for-backend-review
and removed
test-failure
labels
94 tasks
va-vfs-bot
temporarily deployed
to
log-when-form-upload-prefill-is-changed/main/main
pennja
previously approved these changes
Jan 3, 2025
LindseySaari
reviewed
Jan 3, 2025
modules/simple_forms_api/app/services/simple_forms_api/prefill_data_service.rb
Show resolved
Hide resolved
LindseySaari
reviewed
Jan 3, 2025
modules/simple_forms_api/app/controllers/simple_forms_api/v1/scanned_form_uploads_controller.rb
Show resolved
Hide resolved
LindseySaari
reviewed
Jan 3, 2025
modules/simple_forms_api/app/services/simple_forms_api/prefill_data_service.rb
Outdated
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
log-when-form-upload-prefill-is-changed/main/main
LindseySaari
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR logs whenever a user modifies their data from what prefill provided. We don't actually do anything with this but we want to be aware of how much people are able to rely on prefill being accurate.
Related issue(s)
https://github.com/orgs/department-of-veterans-affairs/projects/1443/views/3?sliceBy%5Bvalue%5D=Thrillberg&filterQuery=-status%3AIcebox%2CEpic%2C%22Collab+Cycle%22&pane=issue&itemId=91272272&issue=department-of-veterans-affairs%7CVA.gov-team-forms%7C1931