API-42927-veteran-rep-service-standardization

[stiehlrod]

Summary

• Removes extra methods from definitions file.

Related issue(s)

• API-42927
• API-42320

Testing done

• post '/:veteranId/power-of-attorney-request', to: 'request#create'
• search for wsdl in logs
• test in rails c

if Settings.bgs.ssl_verify_mode == 'none'
OpenSSL::SSL::VERIFY_NONE
else
OpenSSL::SSL::VERIFY_PEER
end
ClaimsApi::LocalBGS.new(external_uid:'a', external_key:'b').fetch_namespace(Faraday::Connection.new(ssl: { verify_mode: @ssl_verify_mode }), 'VDC/VeteranRepresentativeService')

Response

Rails -- ClaimsApi :: local_bgs :: event: connection_wsdl_get :: endpoint: VDC/VeteranRepresentativeService :: duration: 0.598 :: Location: /Users/jennicastiehl/Oddball_Github/vets-api/modules/claims_api/lib/bgs_service/local_bgs.rb:223
=> "http://gov.va.vba.benefits.vdc/services"

What areas of the site does it impact?

modified: modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 255 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/lib/bgs_service/veteran_representative_service.rb (+34/-9) modules/claims_api/lib/bgs_service/veteran_representative_service/create_veteran_representative_request.rb (+0/-17) modules/claims_api/lib/bgs_service/veteran_representative_service/read_all_veteran_representatives.rb (+0/-28) modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb (+6/-18) modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/read_all_veteran_representatives_spec.rb (+51/-88) modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/veteran_representative_service_spec.rb (+3/-1) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[stiehlrod]

@FonzMP Due to the large amounts of change, I am opting to create a new PR in order to re-work the tests that we discussed.

[stevenjcumming]

Is this space intentional?