-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDM-372/sob dgib token service #19553
Conversation
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/post911_sob/dgib/authentication_token_service.rb |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/fixtures/post911_sob/dgib/private_test.pem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backend-review-group approval confirmed. |
* create auth service * Update settings and create test keys * Update test settings * spec test for auth token service * Update codeowners * Linting * fix codeowners
Summary
Related issue(s)
Testing done
require 'post911_sob/dgib/authentication_token_service'
and runPost911SOB::AuthenticationTokenService.call
. It should generate token and you should be able to decode token at jwt.ioScreenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Post-911 Statement of Benefits
Acceptance criteria
Requested Feedback
FYI... Statement of Benefits is currently pretty lightweight pass through service (Post911GIBillStatusController forwards request to lighthouse and returns data). So it was never its own module. We will be adding a second request to retrieve transfer of entitlement information from DGIB. The DGIB connection is specific to SOB, and so a module should be created for Post 911 SOB. In the meantime, however, I'm putting the new logic in lib directory under post911_sob. After feature is successfully tested, we will implement modularization of the app