Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDM-372/sob dgib token service #19553

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

jefftmarks
Copy link
Contributor

@jefftmarks jefftmarks commented Nov 21, 2024

Summary

  • *This work is behind a feature toggle (flipper): No
  • (Summarize the changes that have been made to the platform): Preparing to build interface to connect Post-911 statement of benefits (SOB) on vets-api side with claimant-service on dgib side. First step is to build token generation service to be able to smoke test connection with dgib from staging console.
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?) RSA key stored in aws parameter store used to generate JWT which dgib will validate using JWK provided to them
  • (Which team do you work for, does your team own the maintenance of this component?) Education Data Migration (EDM), yes
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change Token generation didn't exist
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing In rails console, require 'post911_sob/dgib/authentication_token_service' and run Post911SOB::AuthenticationTokenService.call. It should generate token and you should be able to decode token at jwt.io
  • If this work is behind a flipper: No
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature? Build rake task that will allow smoke test of connection in staging console before building out rest of feature

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Post-911 Statement of Benefits

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

FYI... Statement of Benefits is currently pretty lightweight pass through service (Post911GIBillStatusController forwards request to lighthouse and returns data). So it was never its own module. We will be adding a second request to retrieve transfer of entitlement information from DGIB. The DGIB connection is specific to SOB, and so a module should be created for Post 911 SOB. In the meantime, however, I'm putting the new logic in lib directory under post911_sob. After feature is successfully tested, we will implement modularization of the app

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/post911_sob/dgib/authentication_token_service.rb

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/fixtures/post911_sob/dgib/private_test.pem

Copy link
Contributor

@binq binq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Backend-review-group approval confirmed.

@jefftmarks jefftmarks merged commit 6b3064b into master Nov 21, 2024
54 of 55 checks passed
@jefftmarks jefftmarks deleted the EDM-372/sob-dgib-token-service branch November 21, 2024 22:11
SnowboardTechie pushed a commit that referenced this pull request Nov 25, 2024
* create auth service

* Update settings and create test keys

* Update test settings

* spec test for auth token service

* Update codeowners

* Linting

* fix codeowners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants