Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

95914 Add new email template value for form 10-10d failure notifications - IVC CHAMPVA #19120

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

michaelclement
Copy link
Contributor

Summary

  • This PR adds the ID of a new VA Notify email template

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

@va-vfs-bot va-vfs-bot temporarily deployed to 95914-add-new-email-template-id/main/main October 28, 2024 22:03 Inactive
@michaelclement michaelclement marked this pull request as ready for review October 29, 2024 12:13
@michaelclement michaelclement requested review from a team as code owners October 29, 2024 12:13
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches up with the manifest changes 👍

Copy link

Backend-review-group approval confirmed.

@michaelclement michaelclement merged commit 270e3ba into master Oct 30, 2024
36 checks passed
@michaelclement michaelclement deleted the 95914-add-new-email-template-id branch October 30, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants