Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused Settings - Part 1 #19096

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Remove Unused Settings - Part 1 #19096

merged 3 commits into from
Nov 19, 2024

Conversation

stevenjcumming
Copy link
Contributor

@stevenjcumming stevenjcumming commented Oct 25, 2024 •
edited
Loading

Summary

This is part 1 of 3-ish

  • Remove settings from config/settings.yml and config/settings/test.yml
  • Checked using:
    • Dot notation
    • Hash access ([], .dig, fetch)
    • Checked parent key
  • Added comments for difficult to find Settings (willing to remove if undesirable)

Related issue(s)

Testing done

  • n/a

Acceptance criteria

  • Unused settings are removed from config/settings files

@stevenjcumming stevenjcumming requested review from a team as code owners October 25, 2024 19:39
@stevenjcumming stevenjcumming self-assigned this Oct 25, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-remove-unused-settings-1/main/main October 25, 2024 19:41 Inactive
rmtolmach
rmtolmach reviewed Oct 25, 2024
View reviewed changes
config/settings.yml
@@ -86,12 +86,10 @@ sign_in:

terms_of_use:
current_version: v1
provisioner_cookie_domain: localhost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Riley added this last year in #14455. @rileyanderson, we don't see Settings.terms_of_use.provisioner_cookie_domain called anywhere. I just wanted to check with you before we deleted this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Riley and provisioner_cookie_domain isn't being used

@rmtolmach
Copy link
Contributor

Seems good to me. I asked for Riley's review because that key is relatively new compared to the others you're removing. Are any of these values in the manifest repo?

@rmtolmach rmtolmach requested review from a team and rileyanderson October 25, 2024 20:45
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-remove-unused-settings-1/main/main October 25, 2024 22:17 Inactive
@stevenjcumming
Copy link
Contributor Author

@mathisto could you take a look at this PR regarding the updates to appeals_api specs (or anything else if you see something)

mathisto
mathisto requested changes Nov 1, 2024
View reviewed changes
modules/appeals_api/spec/sidekiq/higher_level_review_upload_status_batch_spec.rb
@@ -35,11 +35,9 @@
let(:upload) { create(:higher_level_review_v1, status: 'received') }

it 'ignores them' do
with_settings(Settings.modules_appeals_api, higher_level_review_updater_enabled: true) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that unlike the subsequent files, this batch version's Settings will need to be replaced with the relevant Flipper flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathisto are you saying you would like me to leave with_settings... in the spec?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathisto Can you be more specific about what changes you want here?

@rmtolmach rmtolmach self-requested a review November 5, 2024 16:30
@github-actions GitHub Actions
Copy link

Backend-review-group approval confirmed.

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-remove-unused-settings-1/main/main November 19, 2024 17:07 Inactive
@stevenjcumming stevenjcumming merged commit 1a24f7f into master Nov 19, 2024
21 checks passed
@stevenjcumming stevenjcumming deleted the sjc-remove-unused-settings-1 branch November 19, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmtolmach rmtolmach rmtolmach approved these changes

@rileyanderson rileyanderson Awaiting requested review from rileyanderson

@mathisto mathisto Awaiting requested review from mathisto

Assignees

@stevenjcumming stevenjcumming

Labels
ready-for-backend-review require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenjcumming @rmtolmach @mathisto @va-vfs-bot