Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dex 93107 686 logging and email #19062

Merged
merged 26 commits into from
Nov 8, 2024
Merged

Conversation

evansmith
Copy link
Contributor

@evansmith evansmith commented Oct 24, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): Partially
  • Added ZSF triggers and email notifications to 686c-674 backup submission failure.
  • As part of the ZSF effort we are adding in a call to a silent failure notification and also emails to the claimant/Veteran. We are also logging as we previously did.
  • VA Benefits and Claims.
  • Flipper can be activated when production templates are in place and the relevant PRs have been merged in https://github.com/department-of-veterans-affairs/vsp-infra-application-manifests

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/dependents/monitor.rb

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/dependents/monitor.rb

@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main October 24, 2024 17:13 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main October 24, 2024 17:29 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main October 25, 2024 13:44 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main October 25, 2024 17:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main October 28, 2024 14:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main November 1, 2024 13:55 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main November 1, 2024 17:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main November 4, 2024 18:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dex-93107-686-logging-and-email/main/main November 6, 2024 14:01 Inactive
Copy link

github-actions bot commented Nov 6, 2024

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/lib/dependents/monitor_spec.rb

micahaspyr
micahaspyr previously approved these changes Nov 8, 2024
Copy link
Contributor

@micahaspyr micahaspyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Nov 8, 2024

Backend-review-group approval confirmed.

@evansmith evansmith merged commit 8187862 into master Nov 8, 2024
23 checks passed
@evansmith evansmith deleted the dex-93107-686-logging-and-email branch November 8, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants