PBP 95481 ZSF VA Email Notification

[wayne-weibel]

Summary

add general functionality to send email notification for a SavedClaim

Related issue(s)

ZSF | general claim email notification functionality
https://github.com/department-of-veterans-affairs/vsp-infra-application-manifests/pull/3181
https://github.com/department-of-veterans-affairs/vsp-infra-application-manifests/pull/3185

Testing done

• New code is covered by unit tests
• locally in console:

3.3.3 :001 > require 'va_notify/notification_email/saved_claim'
3.3.3 :002 > c = Pensions::SavedClaim.find(4)
3.3.3 :003 > vne = VANotify::NotificationEmail::SavedClaim.new(c)
3.3.3 :004 > vne.deliver(:confirmation)

Screenshots

What areas of the site does it impact?

pension and burial at the moment. any other saved claim form can use this class by extending or directly

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• I added a screenshot of the developed feature

Requested Feedback

Should the rescue also reraise the exception? My thinking in not doing so is that the send of the email should not be a requirement to continue the calling process, and there is the monitoring of success/failure (at least for calling the EmailJob.perform)

[github-actions]

1 Warning

⚠️

This PR changes 398 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files .github/CODEOWNERS (+3/-0) app/models/saved_claim.rb (+16/-0) app/models/saved_claim/burial.rb (+8/-21) app/sidekiq/lighthouse/submit_benefits_intake_claim.rb (+2/-0) config/settings.yml (+20/-2) lib/va_notify/notification_email.rb (+40/-0) lib/va_notify/notification_email/burial.rb (+25/-0) lib/va_notify/notification_email/saved_claim.rb (+84/-0) modules/pensions/app/models/pensions/saved_claim.rb (+2/-27) modules/pensions/app/sidekiq/pensions/pension_benefit_intake_job.rb (+2/-1) modules/pensions/lib/pensions/notification_email.rb (+14/-0) modules/pensions/spec/models/pensions/saved_claim_spec.rb (+5/-15) modules/pensions/spec/sidekiq/pensions/pension_benefit_intake_job_spec.rb (+6/-1) spec/factories/saved_claim.rb (+28/-0) spec/lib/va_notify/notification_email/saved_claim_spec.rb (+71/-0) spec/sidekiq/lighthouse/submit_benefits_intake_claim_spec.rb (+4/-1) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[rmtolmach]

There was a seemingly-unrelated test failure. I'm re-running them for you.

[rmtolmach]

Maybe it is related. It keeps failing on your branch and I don't see it failing on master https://github.com/department-of-veterans-affairs/vets-api/commits/master/
Here's one. but see the test output for more failures.

  1) SavedClaim::EducationBenefits::VA10203#after_submit calls get_gi_bill_status on the service
     Failure/Error: Settings.vanotify.services.va_gov.template_id.form21_10203_confirmation_email,

     NoMethodError:
       undefined method `template_id' for nil
     # ./app/models/saved_claim/education_benefits/va_10203.rb:121:in `send_confirmation_email'
     # ./app/models/saved_claim/education_benefits/va_10203.rb:22:in `after_submit'
     # ./spec/models/saved_claim/education_benefits/va10203_spec.rb:31:in `block (3 levels) in <top (required)>'
     # /usr/local/bundle/cache/ruby/3.3.0/gems/webmock-3.24.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
     # /usr/local/bundle/cache/ruby/3.3.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
     # /usr/local/bundle/cache/ruby/3.3.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
     # /usr/local/bundle/cache/ruby/3.3.0/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # /usr/local/bundle/cache/ruby/3.3.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'

[wayne-weibel]

Maybe it is related. It keeps failing on your branch and I don't see it failing on master https://github.com/department-of-veterans-affairs/vets-api/commits/master/ Here's one. but see the test output for more failures.

that was a different one from what i was seeing before - i merged master again and will be checking more closely if it fails

[rmtolmach]

Maybe it is related. It keeps failing on your branch and I don't see it failing on master https://github.com/department-of-veterans-affairs/vets-api/commits/master/ Here's one. but see the test output for more failures.

that was a different one from what i was seeing before - i merged master again and will be checking more closely if it fails

👍 And I re-ran the test suite twice, so it had three passing runs.

@wayne-weibel Can you get a teammate to review?

[TaiWilkin]

Looks good

[github-actions]

Backend-review-group approval confirmed.