[DBX-94127/94128] add 526 backup failure email job

[SamStuckey]

Summary

• This work is behind a feature toggle (flipper): NO (usecase will be)
• Add service for sending failure emails to veterans. unblocks following work:
  • leverage service in backup submission exhaustion
  • leverage service in backup polling on failure result
• blocks this PR

Related issue(s)

• Ticket
• Ticket 2

Testing done

• New code is covered by unit tests
• flipper will enable integration testing in staging
• all objects load and functions tested via local command line

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/form526_submission_failure_email_job.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/form526_submission_failure_email_job.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/form526_submission_failure_email_job.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/form526_submission_failure_email_job.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/form526_submission_failure_email_job.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/form526_submission_failure_email_job.rb

[github-actions]

1 Warning

⚠️

This PR changes 272 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files .github/CODEOWNERS (+2/-0) app/sidekiq/form526_submission_failure_email_job.rb (+119/-0) config/settings.yml (+1/-0) spec/factories/form526_submissions.rb (+12/-0) spec/sidekiq/form526_submission_failure_email_job_spec.rb (+138/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/form526_submission_failure_email_job.rb

[SamStuckey]

Just to confirm, this PR is just putting the class in, it is not putting in anything that actually uses the class yet, right?

If so, just making a note that we may also need to add a silent_failure tag into wherever you are queuing this job, in the case that you fail to queue the job or throw an error when/before queuing it.

correct, subsequent PR leverages this. We can discuss adding that extra tag in that PR : )

[kylesoskin]

small spelling nit-pick, but all good!

[github-actions]

Backend-review-group approval confirmed.