Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace sidekiq_alive with built-in Health Check #17784

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ericboehs
Copy link
Contributor

@ericboehs ericboehs commented Jul 30, 2024

This replaces the sidekiq_alive gem with the built-in Sidekiq Enterprise Health Check. No changes are needed in Helm/Manifest Values.

Screenshot 2024-07-30 at 11 19 41@2x

@ericboehs ericboehs requested review from a team as code owners July 30, 2024 15:49
@ericboehs ericboehs marked this pull request as draft July 30, 2024 15:49
@va-vsp-bot

This comment was marked as outdated.

@ericboehs ericboehs force-pushed the eb-remove-sidekiq-alive branch from 61a7820 to 58b31a8 Compare July 30, 2024 16:04
@ericboehs ericboehs force-pushed the eb-remove-sidekiq-alive branch from 58b31a8 to 2afd6e0 Compare July 30, 2024 16:16
@ericboehs ericboehs marked this pull request as ready for review July 30, 2024 16:20
@ericboehs ericboehs enabled auto-merge (squash) July 30, 2024 16:20
@ericboehs ericboehs disabled auto-merge July 30, 2024 16:27
@va-vfs-bot va-vfs-bot temporarily deployed to eb-remove-sidekiq-alive/main/main July 30, 2024 16:41 Inactive
@ericboehs ericboehs changed the title chore: Remove sidekiq_alive gem chore: Replace sidekiq_alive gem with built-in Health Check Jul 30, 2024
@ericboehs ericboehs changed the title chore: Replace sidekiq_alive gem with built-in Health Check chore: Replace sidekiq_alive with built-in Health Check Jul 30, 2024
@ericboehs ericboehs enabled auto-merge (squash) July 30, 2024 17:24
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for linking the docs.

@ericboehs ericboehs merged commit 8489231 into master Jul 30, 2024
18 checks passed
@ericboehs ericboehs deleted the eb-remove-sidekiq-alive branch July 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants