MHV-58591 MHV-57739 Authentication for MHV Classic radiology endpoint

[mmoyer-va]

Summary

• Added a new Radiology controller that communicates to MHV Classic, returning a list of radiology records
• This work necessitated authenticating to a different MHV session endpoint
• The session creation also calls a patient endpoint to get the patient ID

Related issue(s)

MHV-58591 - Add containerized authorization endpoint to radiology API calls

Add containerized authentication endpoint to radiology API calls

Handle the reducer in the front end for radiology

Feature Flag Y/N ? N

DataDog/Analytics Y/N ? N

Manual Testing Y/N ? N

Automated Testing Y/N ? N

Accessibility Testing Y/N ? N

UCD Validation Y/N N

Acceptance Criteria:

AC1 Radiology vets api endpoint works fully and returns a list of radiology reports

AC2 Handle the reducer in the front end for radiology

AC3
AC4
AC5

Links to UCD:

Figma Link:

User Flow:

Mobile:

Desktop:

Other Design Notes:

Architectural Notes: Always check for the latest designs in Figma

MHV-57739 - Connect vets-api to MHV radiology API(s)

Connect vets-api to MHV radiology API(s)

Feature Flag Y/N ? N

DataDog/Analytics Y/N ? N

Manual Testing Y/N ? 

Automated Testing Y/N ? N

Accessibility Testing Y/N ? N

UCD Validation Y/N N

Acceptance Criteria:

AC1  Connection of vets-api to MHV radiology API(s) is complete

AC2

AC3
AC4
AC5

Links to UCD:

Figma Link:

User Flow:

Mobile:

Desktop:

Other Design Notes:

Architectural Notes: Always check for the latest designs in Figma

Testing done

• New tests at the client and controller level
• Updated existing tests to account for modified mr_controller code

Screenshots

Note: Optional

What areas of the site does it impact?

MHV Medical Records

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 300 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files config/locales/exceptions.en.yml (+20/-0) config/redis.yml (+6/-0) lib/medical_records/bb_internal/client.rb (+63/-0) lib/medical_records/bb_internal/client_session.rb (+14/-0) lib/medical_records/bb_internal/configuration.rb (+65/-0) modules/my_health/app/controllers/my_health/mr_controller.rb (+10/-0) modules/my_health/app/controllers/my_health/v1/medical_records/radiology_controller.rb (+14/-0) modules/my_health/config/routes.rb (+7/-4) modules/my_health/spec/request/v1/allergies_request_spec.rb (+2/-0) modules/my_health/spec/request/v1/clinical_notes_request_spec.rb (+2/-0) modules/my_health/spec/request/v1/conditions_request_spec.rb (+2/-0) modules/my_health/spec/request/v1/labs_and_tests_request_spec.rb (+2/-0) modules/my_health/spec/request/v1/medical_records/mr_session_request_spec.rb (+2/-0) modules/my_health/spec/request/v1/medical_records/radiology_request_spec.rb (+50/-0) modules/my_health/spec/request/v1/vaccines_request_spec.rb (+2/-0) modules/my_health/spec/request/v1/vitals_request_spec.rb (+2/-0) spec/lib/medical_records/bb_internal/client_spec.rb (+33/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[mattwrightva]

Awesome!

[stevenjcumming]

@mmoyer-va could you refactor line 18 better spacing/readability. For example:

Suggested change

	before do
	allow(MedicalRecords::Client).to receive(:new).and_return(authenticated_client)
	allow(BBInternal::Client).to receive(:new).and_return(BBInternal::Client.new(
	session: { user_id: 15_176_497,
	patient_id: '15176498',
	expires_at: Time.current + (60 * 60),
	token: 'SESSION_TOKEN' }
	))
	sign_in_as(current_user)
	end
	before do
	bb_internal_client = BBInternal::Client.new(
	session: {
	user_id: 15_176_497,
	patient_id: '15176498',
	expires_at: Time.current + 1.hour,
	token: 'SESSION_TOKEN'
	}
	)
	allow(MedicalRecords::Client).to receive(:new).and_return(authenticated_client)
	allow(BBInternal::Client).to receive(:new).and_return(bb_internal_client)
	sign_in_as(current_user)
	end

[mmoyer-va]

@stevenjcumming thank you for the suggestion -- this is much better.