Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to va_online_scheduling_status_improvement feature flag #17277

Merged

Conversation

JunTaoLuo
Copy link
Contributor

Summary

  • Removing obsolete feature flag

Related issue(s)

Testing done

  • Ensured existing tests pass

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@JunTaoLuo JunTaoLuo requested review from a team as code owners June 26, 2024 17:09
@LindseySaari
Copy link
Contributor

@JunTaoLuo Reminder: Please open a support request so that we can manually remove the removed feature toggle in live envs. They are not auto removed from the DB and need to be manually removed according to the documentation (see 3a here)

@JunTaoLuo
Copy link
Contributor Author

@LindseySaari We have an issue tracking the list of feature flags we need to remove in the production environment here. Since we still need to remove several more feature flags, we'll file the support request for all of them at once to hopefully make it simpler to deal with. FYI I have been removing the feature flags in the non-production environments (dev, staging, sandbox) so we only need support for removing the flags in the production environment.

@JunTaoLuo JunTaoLuo merged commit 5465ac2 into master Jun 26, 2024
19 of 20 checks passed
@JunTaoLuo JunTaoLuo deleted the jtluo/remove-va_online_scheduling_status_improvement branch June 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants