Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove va_online_scheduling_GA4_migration feature toggle #17031

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jun 6, 2024

Summary

  • Removing va_online_scheduling_GA4_migration feature toggle which is now obsolete.

Related issue(s)

Testing done

  • Ensure existing test suite passes

Acceptance criteria

  • Remove any references of the feature toggle va_online_scheduling_GA4_migration
  • Changes have been updated in vets-api
  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@JunTaoLuo JunTaoLuo requested review from a team as code owners June 6, 2024 14:40
@va-vfs-bot va-vfs-bot temporarily deployed to jtluo/remove-ga4-feature-toggle/jtluo/remove-ga4-feature-toggle/main June 6, 2024 14:42 Inactive
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ Deletions.

@JunTaoLuo JunTaoLuo requested review from ryanshaw and cferris32 June 7, 2024 13:43
@JunTaoLuo JunTaoLuo merged commit 2469e26 into master Jun 12, 2024
20 checks passed
@JunTaoLuo JunTaoLuo deleted the jtluo/remove-ga4-feature-toggle branch June 12, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants