Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to va_online_scheduling_required_schedulable_param feature flag #16096

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

JunTaoLuo
Copy link
Contributor

Summary

This PR removes the obsolete feature flag va_online_scheduling_required_schedulable_param and its references in this repo. This flag is currently enabled in staging and production.

For testing disable the following feature flags and confirm scheduling appointments are working as expected. Refer to this checklist for a full list of scenarios.

Related issue(s)

Testing done

  • New code is covered by existing unit tests
  • Prior to this change, schedulable is forced to true only if the feature flag is enabled. Now the feature flag is removed, this parameter is always set to true.
  • Regression tests for the current behavior is tested without setting the va_online_scheduling_required_schedulable_param flag to be true

Screenshots

N/A

What areas of the site does it impact?

Appointments (VAOS)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@JunTaoLuo JunTaoLuo requested review from a team as code owners March 26, 2024 21:08
@JunTaoLuo JunTaoLuo force-pushed the jtluo/remove-schedulable-feature-flag branch from 1aa9413 to 4bcdcfb Compare March 26, 2024 21:08
@va-vfs-bot va-vfs-bot temporarily deployed to jtluo/remove-schedulable-feature-flag/jtluo/remove-schedulable-feature-flag/main March 26, 2024 21:18 Inactive
Copy link
Contributor

@ajmagdub ajmagdub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunTaoLuo JunTaoLuo merged commit 390edec into master Mar 28, 2024
20 checks passed
@JunTaoLuo JunTaoLuo deleted the jtluo/remove-schedulable-feature-flag branch March 28, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove any references of va_online_scheduling_required_schedulebale_param feature toggle - (vets-api)
4 participants