Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-56069-Update-rxRfRecords-structure #16046

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

agravell047
Copy link
Contributor

Summary

Updated the rxRfRecords field to return an array of strings.

Related issue(s)

https://jira.devops.va.gov/browse/MHV-56069

AC1: fix rxRfRecords data structure on vets-api to return an array of refill history data

Testing done

  • Tested locally
  • Ran unit tests

What areas of the site does it impact?

MHV Medications app

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@agravell047 agravell047 requested review from a team as code owners March 21, 2024 20:41
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-56069-Update-RxRfRecords-Structure/MHV-56069-Update-RxRfRecords-Structure/main March 21, 2024 21:06 Inactive
LindseySaari
LindseySaari previously approved these changes Mar 22, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-56069-Update-RxRfRecords-Structure/MHV-56069-Update-RxRfRecords-Structure/main March 22, 2024 13:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-56069-Update-RxRfRecords-Structure/MHV-56069-Update-RxRfRecords-Structure/main March 22, 2024 14:27 Inactive
Copy link
Contributor

@dcloud dcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is great since it adds test coverage that was missing. I left a comment about the conditional in the test for 'rx_rf_records', where I think we want to assert some control over our factory instance for testing presence/absence of those records

@va-vfs-bot va-vfs-bot temporarily deployed to MHV-56069-Update-RxRfRecords-Structure/MHV-56069-Update-RxRfRecords-Structure/main March 22, 2024 15:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-56069-Update-RxRfRecords-Structure/MHV-56069-Update-RxRfRecords-Structure/main March 22, 2024 16:15 Inactive
Copy link
Contributor

@dcloud dcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback. I think this is good to go! 🚢

@agravell047 agravell047 merged commit a36a079 into master Mar 22, 2024
20 checks passed
@agravell047 agravell047 deleted the MHV-56069-Update-RxRfRecords-Structure branch March 22, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants