-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHV-56069-Update-rxRfRecords-structure #16046
Conversation
d149ef1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this is great since it adds test coverage that was missing. I left a comment about the conditional in the test for 'rx_rf_records'
, where I think we want to assert some control over our factory instance for testing presence/absence of those records
modules/my_health/spec/serializer/v1/prescription_details_serializer_spec.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback. I think this is good to go! 🚢
Summary
Updated the rxRfRecords field to return an array of strings.
Related issue(s)
https://jira.devops.va.gov/browse/MHV-56069
Testing done
What areas of the site does it impact?
MHV Medications app
Acceptance criteria