Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Update lighthouse maintenance windows #15997

Merged
merged 8 commits into from
Mar 21, 2024

Conversation

Tonksthebear
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

Updates the maintenance windows for mobile to respect new lighthouse PagerDuty services, along with further upstream services

Related issue(s)

department-of-veterans-affairs/va-mobile-app#8163

Testing done

Existing tests cover the functionality

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Tonksthebear
Copy link
Contributor Author

I will pull this out of prod and fix tests when I get final confirmation that EVSS can be removed as a dependency to Lighthouse

@va-vfs-bot va-vfs-bot temporarily deployed to mobile-maintenance-windows-updates/main/main March 18, 2024 22:35 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to mobile-maintenance-windows-updates/main/main March 20, 2024 21:49 Inactive
@Tonksthebear
Copy link
Contributor Author

Ok learned a lot that's worth sharing.

I removed a couple lighthouse dependencies because they aren't flipped yet.

Found out that the new maintenance windows being tracked (lighthouse_direct_deposit, lighthouse_vshe) were manually added by Tom Harrison and he/his team manually updates PagerDuty with the maintenance windows. He bases the status on the Lighthouse StatusPage which I confirmed in a thread DOES actually take into account the upstream services above lighthouse, meaning we shouldn't need to worry about the upstream service mayhem beyond our lighthouse endpoints because they're accounting for those maintenance windows.

There are two big questions, one that we need to decide

  1. How do we automate the lighthouse status page populating PagerDuty (working on this with Tom)
  2. How do WE account for maintenance windows and Flipper? Do we ignore updating our maintenance windows to lighthouse until we've flipped it to 100% Or do we add flipper logic to maintenance windows?

In either case, Tom knows the process of adding new maintenance windows to the white list so if we solve automation, we should be able to breakdown lighthouse to however many maintenance windows we want

@Tonksthebear Tonksthebear marked this pull request as ready for review March 20, 2024 21:56
@Tonksthebear Tonksthebear requested a review from a team as a code owner March 20, 2024 21:56
@va-vfs-bot va-vfs-bot temporarily deployed to mobile-maintenance-windows-updates/main/main March 20, 2024 21:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to mobile-maintenance-windows-updates/main/main March 20, 2024 22:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to mobile-maintenance-windows-updates/main/main March 20, 2024 23:32 Inactive
kpethtel
kpethtel previously approved these changes Mar 21, 2024
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand this correctly, bgs, mpi, and vbms all turn off claims. I don't see an immunizations flag in the ticket. Does that exist? I wouldn't have expected [immunizations] to work but I haven't looked at the underlying code in a long time.

Nice work figuring out who actually knows about maintenance windows. It's progress. Seems like this will be an ongoing project.

%i[lighthouse direct_deposit_benefits],
%i[lighthouse disability_rating],
%i[lighthouse letters_and_documents],
%i[lighthouse immunizations],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that lighthouse should take down immunizations. Did you get info from someone to the contrary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, forgot to push that change. I originally removed it because I was going to skip lighthouse altogether because currently pager duty is manually populated. I meant to add it back though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to be clear, if any of bgs, mpi, or vbms is down, then claims and immunizations are down? So we know that immunizations relies on all three of those?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing that, if it's wrong, is part of the larger ticket. This was just to decouple evss and lighthouse.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya there will be another ticket to breakdown lighthouse into a maintenance window for each endpoint we use. That process is all still being talked about but we'll be able to make this more specific

@kpethtel
Copy link
Contributor

So if I understand this correctly, bgs, mpi, and vbms all turn off claims. I don't see an immunizations flag in the ticket. Does that exist? I wouldn't have expected [immunizations] to work but I haven't looked at the underlying code in a long time.

Nice work figuring out who actually knows about maintenance windows. It's progress. Seems like this will be an ongoing project.

I just checked how the service graph works. [immunizations] works because it's both the first and last entry in the array. 👍

@va-vfs-bot va-vfs-bot temporarily deployed to mobile-maintenance-windows-updates/main/main March 21, 2024 17:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to mobile-maintenance-windows-updates/main/main March 21, 2024 17:24 Inactive
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And I agree that given how often we have to feature flag in order to shift upstreams, it probably makes sense to refactor maintenance windows to respect feature flags.

@Tonksthebear Tonksthebear requested a review from kpethtel March 21, 2024 17:50
@Tonksthebear Tonksthebear merged commit 76164a6 into master Mar 21, 2024
20 checks passed
@Tonksthebear Tonksthebear deleted the mobile-maintenance-windows-updates branch March 21, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants