Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused Yellow Ribbon feature toggles #15996

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

stevelong00
Copy link
Contributor

@stevelong00 stevelong00 commented Mar 18, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): NO
  • Removed two unused flipper toggles
  • Not a bug
  • Team IIR, we are the current owners

Related issue(s)

https://github.com/department-of-veterans-affairs/va-iir/issues/465
https://github.com/department-of-veterans-affairs/va-iir/issues/242

Testing done

  • New code is covered by unit tests
  • Prior to this change, two unused feature toggles appeared in flipper
  • To verify, navigate to http://localhost:3000/flipper/features and confirm that these two toggles do not appear
  • Testing consisted of a code search to confirm that these toggles are unused

Screenshots

None

What areas of the site does it impact?

This only affects flipper

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

None

@stevelong00 stevelong00 requested review from a team as code owners March 18, 2024 22:13
@va-vfs-bot va-vfs-bot temporarily deployed to 465-remove-BE-feature-toggle/465-remove-BE-feature-toggle/main March 18, 2024 22:25 Inactive
Copy link
Contributor

@khenson-oddball khenson-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevelong00 stevelong00 merged commit 4d3f645 into master Mar 25, 2024
20 checks passed
@stevelong00 stevelong00 deleted the 465-remove-BE-feature-toggle branch March 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants