Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add va_online_scheduling_enable_OH_slots_search feature flag #15980

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

devin-mccurdy
Copy link
Contributor

@devin-mccurdy devin-mccurdy commented Mar 18, 2024

Summary

  • This work is behind a feature toggle (flipper): NO
  • This PR adds a feature flag that will route appointment slot search operations to the new VPG service if enabled. If it is disabled appointment slot search operations will continue to use vaos-service.
  • Unified Appointment Experience team
  • The success criteria being targeted is the ability to support appointment operations at Oracle Health sites by using VPG for searching appointment slots instead of vaos-service.

Related issue(s)

department-of-veterans-affairs/va.gov-team#76083

Testing done

What areas of the site does it impact?

This change only impacts flipper

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to 76083-add-vpg-feature-flag/main/main March 18, 2024 16:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 76083-add-vpg-feature-flag/main/main March 18, 2024 17:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 76083-add-vpg-feature-flag/main/main March 21, 2024 17:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 76083-add-vpg-feature-flag/main/main March 21, 2024 19:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 76083-add-vpg-feature-flag/main/main March 21, 2024 20:10 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 76083-add-vpg-feature-flag/main/main March 21, 2024 20:42 Inactive
@drewconnelly
Copy link
Contributor

LGTM

@devin-mccurdy devin-mccurdy marked this pull request as ready for review March 22, 2024 13:50
@devin-mccurdy devin-mccurdy requested review from a team as code owners March 22, 2024 13:50
@devin-mccurdy devin-mccurdy merged commit 831b9ed into master Mar 22, 2024
20 checks passed
@devin-mccurdy devin-mccurdy deleted the 76083-add-vpg-feature-flag branch March 22, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants