Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MHV-49867 Filter out inactive FHIR records #14004

Merged
merged 0 commits into from
Oct 3, 2023
Merged

MHV-49867 Filter out inactive FHIR records #14004

merged 0 commits into from
Oct 3, 2023

Conversation

mmoyer-va
Copy link
Contributor

@mmoyer-va mmoyer-va commented Oct 2, 2023 •
edited
Loading

Summary

  • Due to recent changes to the MHV MR FHIR APIs, we now need to specifically request only active records.
  • Quick change to session's redis key, making it ICN instead of MHV Correlation ID, per Patrick's comment here: MHV-49842 Authenticate to MHV FHIR using ICN #13969 (comment)
  • Updated CODEOWNERS to better reflect medical records file ownership

Related issue(s)

MHV-49867 - Filter FHIR records to select only "active" records

Because of the way we are now handling "entered-in-error" records, we will need to make sure we only display active records in the frontend.

This can be done by filtering when making the FHIR call.

Append "clinical-status=active"

Testing done

  • Updated the relevant VCR cassettes to reflect the new API calls
  • Verified manually that passing the new parameter returns the right results to the user interface

Screenshots

Note: Optional

What areas of the site does it impact?

MHV Medical Records

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vsp-bot va-vsp-bot requested a deployment to MHV-49867-filter-inactive-records/main/main October 2, 2023 19:15 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-49867-filter-inactive-records/main/main October 2, 2023 19:29 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to MHV-49867-filter-inactive-records/main/main October 2, 2023 19:34 In progress
Wyzardsleeves
Wyzardsleeves previously approved these changes Oct 2, 2023
View reviewed changes
Copy link

@Wyzardsleeves Wyzardsleeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@mmoyer-va mmoyer-va marked this pull request as ready for review October 2, 2023 19:38
@mmoyer-va mmoyer-va requested review from a team October 2, 2023 19:38
mattwrightva
mattwrightva previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@mattwrightva mattwrightva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@va-vfs-bot va-vfs-bot temporarily deployed to MHV-49867-filter-inactive-records/main/main October 2, 2023 20:14 Inactive
@rmtolmach
Copy link
Contributor

@mmoyer-va Please fix failing tests.

@mmoyer-va mmoyer-va dismissed stale reviews from mattwrightva and Wyzardsleeves via 037639f October 3, 2023 14:47
@va-vsp-bot va-vsp-bot requested a deployment to MHV-49867-filter-inactive-records/main/main October 3, 2023 14:48 In progress
@va-vsp-bot va-vsp-bot requested a deployment to MHV-49867-filter-inactive-records/main/main October 3, 2023 14:49 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-49867-filter-inactive-records/main/main October 3, 2023 15:00 Inactive
@mmoyer-va
Copy link
Contributor Author

@mmoyer-va Please fix failing tests.

@rmtolmach Sorry about that! I thought I had updated all the relevant tests but I missed a batch.

rmtolmach
rmtolmach approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeowners changes look good.

@mmoyer-va mmoyer-va merged this pull request into master Oct 3, 2023
@mmoyer-va mmoyer-va deleted the MHV-49867-filter-inactive-records branch October 3, 2023 20:21
lindluni pushed a commit that referenced this pull request Dec 1, 2023
@mmoyer-va
MHV-49867 Filter out inactive FHIR records (#14004)
274c811 
* MHV-49867 Only return active FHIR records when searching

* MHV-49867 Updated unit test cassettes

* MHV MR session redis key changed to ICN

* Updated CODEOWNERS file for vfs-mhv-medical-records items

* MHV-49867 Fixed failing unit tests

* MHV-49867 Fixed another failing test
tsr-rise8 pushed a commit that referenced this pull request Dec 6, 2023
@mmoyer-va
MHV-49867 Filter out inactive FHIR records (#14004)
c8932c6 
* MHV-49867 Only return active FHIR records when searching

* MHV-49867 Updated unit test cassettes

* MHV MR session redis key changed to ICN

* Updated CODEOWNERS file for vfs-mhv-medical-records items

* MHV-49867 Fixed failing unit tests

* MHV-49867 Fixed another failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmtolmach rmtolmach rmtolmach approved these changes

@Wyzardsleeves Wyzardsleeves Wyzardsleeves left review comments

@mattwrightva mattwrightva mattwrightva left review comments

Assignees
No one assigned
Labels
console-services-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmoyer-va @rmtolmach @Wyzardsleeves @mattwrightva @va-vfs-bot @va-vsp-bot