-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10-10CG - Sign as a Rep BUG: Update document_type value to match update from CARMA #13965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshingYou1
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work resolving this bug Lihan! 😃
rmtolmach
approved these changes
Oct 11, 2023
lindluni
pushed a commit
that referenced
this pull request
Dec 1, 2023
…te from CARMA (#13965) * change poa to legal rep * Revert "change poa to legal rep" This reverts commit 6e9d008321276f56addef004e20d3dcf584f3099. * change poa to legal rep * update comments * lint * redeploy review * change all document type refs to legal rep * fix service spec * remove unused constant * fix attachment spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change 1010cg document type from POA to Legal Representative
I work for the 1010 team, we own this code.
Related issue(s)
department-of-veterans-affairs/va.gov-team#66189
Testing done
unit tests
tested in review instance and verified with mulesoft team
What areas of the site does it impact?
1010cg form
Acceptance criteria