Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10-10CG - Sign as a Rep BUG: Update document_type value to match update from CARMA #13965

Merged
merged 0 commits into from
Oct 11, 2023

Conversation

lihanli
Copy link
Contributor

@lihanli lihanli commented Sep 28, 2023

Summary

Change 1010cg document type from POA to Legal Representative

  • (Which team do you work for, does your team own the maintainence of this component?)
    I work for the 1010 team, we own this code.

Related issue(s)

department-of-veterans-affairs/va.gov-team#66189

Testing done

unit tests
tested in review instance and verified with mulesoft team

What areas of the site does it impact?

1010cg form

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@va-vsp-bot va-vsp-bot requested a deployment to 1010cg-poa-change/main/main September 28, 2023 14:46 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 1010cg-poa-change/main/main September 28, 2023 14:47 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 1010cg-poa-change/main/main September 28, 2023 14:47 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 1010cg-poa-change/main/main September 28, 2023 14:52 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 1010cg-poa-change/main/main September 28, 2023 15:31 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 1010cg-poa-change/main/main September 28, 2023 15:34 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 1010cg-poa-change/main/main October 4, 2023 18:14 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 1010cg-poa-change/main/main October 4, 2023 18:19 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 1010cg-poa-change/main/main October 5, 2023 18:50 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 1010cg-poa-change/main/main October 5, 2023 18:51 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 1010cg-poa-change/main/main October 5, 2023 18:52 In progress
@va-vsp-bot va-vsp-bot requested a deployment to 1010cg-poa-change/main/main October 5, 2023 18:53 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 1010cg-poa-change/main/main October 5, 2023 18:56 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 1010cg-poa-change/main/main October 5, 2023 20:28 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 1010cg-poa-change/main/main October 5, 2023 20:52 Inactive
@lihanli lihanli changed the title 1010cg poa change 10-10CG - Sign as a Rep BUG: Update document_type value to match update from CARMA Oct 6, 2023
@lihanli lihanli marked this pull request as ready for review October 6, 2023 15:48
@lihanli lihanli requested review from a team October 6, 2023 15:48
Copy link
Contributor

@JoshingYou1 JoshingYou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work resolving this bug Lihan! 😃

@lihanli lihanli merged this pull request into master Oct 11, 2023
@lihanli lihanli deleted the 1010cg-poa-change branch October 11, 2023 16:16
lindluni pushed a commit that referenced this pull request Dec 1, 2023
…te from CARMA (#13965)

* change poa to legal rep

* Revert "change poa to legal rep"

This reverts commit 6e9d008321276f56addef004e20d3dcf584f3099.

* change poa to legal rep

* update comments

* lint

* redeploy review

* change all document type refs to legal rep

* fix service spec

* remove unused constant

* fix attachment spec
tsr-rise8 pushed a commit that referenced this pull request Dec 6, 2023
…te from CARMA (#13965)

* change poa to legal rep

* Revert "change poa to legal rep"

This reverts commit 55dddbc.

* change poa to legal rep

* update comments

* lint

* redeploy review

* change all document type refs to legal rep

* fix service spec

* remove unused constant

* fix attachment spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants