Fixing specs that aren't passing locally (#9864)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>

lib/mdot/response.rb

@@ -4,6 +4,7 @@
 require_relative 'eligibility'
 require_relative 'supply'
 require_relative 'token'
+require_relative 'address'
 
 module MDOT
   class Response < Common::Base

modules/dhp_connected_devices/spec/services/dhp_connected_devices/website_host_service_spec.rb

@@ -6,47 +6,61 @@
   subject { described_class.new }
 
   describe 'website_host_service#get_redirect_url' do
-    old_value = Settings.vsp_environment
-    vendor = 'fitbit'
-    after do
-      # cleanup Settings mock
-      allow(Settings).to receive(:vsp_environment).and_call_original
-      expect(Settings.vsp_environment).to eq(old_value)
+    let(:vendor) { 'fitbit' }
+    let(:environment) { nil }
+
+    before do
+      allow(Settings).to receive(:vsp_environment).and_return(environment)
     end
 
-    it 'nil redirects to localhost:3001' do
-      allow(Settings).to receive(:vsp_environment).and_return(nil)
-      redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
+    context 'when environment is not defined' do
+      let(:environment) { nil }
+
+      it 'redirects to localhost:3001' do
+        redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
 
-      expect(redirect_url).to eq 'http://localhost:3001/health-care/connected-devices/?fitbit=status#_=_'
+        expect(redirect_url).to eq 'http://localhost:3001/health-care/connected-devices/?fitbit=status#_=_'
+      end
     end
 
-    it 'dev redirects to dev.va.gov' do
-      allow(Settings).to receive(:vsp_environment).and_return('development')
-      redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
+    context 'when environment is dev' do
+      let(:environment) { 'development' }
+
+      it 'redirects to dev.va.gov' do
+        redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
 
-      expect(redirect_url).to eq 'https://dev.va.gov/health-care/connected-devices/?fitbit=status#_=_'
+        expect(redirect_url).to eq 'https://dev.va.gov/health-care/connected-devices/?fitbit=status#_=_'
+      end
     end
 
-    it 'staging redirects to staging.va.gov' do
-      allow(Settings).to receive(:vsp_environment).and_return('staging')
-      redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
+    context 'when environment is staging' do
+      let(:environment) { 'staging' }
 
-      expect(redirect_url).to eq 'https://staging.va.gov/health-care/connected-devices/?fitbit=status#_=_'
+      it 'redirects to staging.va.gov' do
+        redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
+
+        expect(redirect_url).to eq 'https://staging.va.gov/health-care/connected-devices/?fitbit=status#_=_'
+      end
     end
 
-    it 'sandbox redirects to dev.va.gov' do
-      allow(Settings).to receive(:vsp_environment).and_return('sandbox')
-      redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
+    context 'when environment is sandbox' do
+      let(:environment) { 'sandbox' }
+
+      it 'redirects to dev.va.gov' do
+        redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
 
-      expect(redirect_url).to eq 'https://dev.va.gov/health-care/connected-devices/?fitbit=status#_=_'
+        expect(redirect_url).to eq 'https://dev.va.gov/health-care/connected-devices/?fitbit=status#_=_'
+      end
     end
 
-    it 'production redirects to va.gov' do
-      allow(Settings).to receive(:vsp_environment).and_return('production')
-      redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
+    context 'when environment is production' do
+      let(:environment) { 'production' }
+
+      it 'redirects to va.gov' do
+        redirect_url = subject.get_redirect_url({ status: 'status', vendor: vendor })
 
-      expect(redirect_url).to eq 'https://www.va.gov/health-care/connected-devices/?fitbit=status#_=_'
+        expect(redirect_url).to eq 'https://www.va.gov/health-care/connected-devices/?fitbit=status#_=_'
+      end
     end
   end
 end

spec/lib/debt_management_center/payments_service_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'debt_management_center/payments_service'
 
 describe DebtManagementCenter::PaymentsService do
   let(:user) { build(:user, :loa3) }