Fix Rubocop/RSpec 2 (#20302)

* delete comments

* Fix RSpec/ChangeByZero

* Fix RSpec/ClassCheck

* Fix RSpec/ExcessiveDocstringSpacing

* Fix RSpec/SortMetadata

* RSpec/VerifiedDoubleReference

* delete comments + codeowners

.github/CODEOWNERS

@@ -1352,6 +1352,7 @@ spec/sidekiq/central_mail/submit_central_form686c_job_spec.rb @department-of-vet
 spec/sidekiq/copay_notifications @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/cypress_viewport_updater/cypress_config_js_file_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/cypress_viewport_updater/github_service_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/sidekiq/cypress_viewport_updater/update_cypress_viewports_job_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/cypress_viewport_updater/viewport_preset_js_file_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/decision_review @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/education_form @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group

.rubocop_todo.yml

@@ -303,79 +303,6 @@ Naming/VariableNumber:
     - 'spec/sidekiq/facilities/state_cemetery_reload_job_spec.rb'
     - 'spec/sidekiq/form1010cg/delete_old_uploads_job_spec.rb'
 
-# Offense count: 1075
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# RSpec/BeEq:
-#   Enabled: false
-
-# Offense count: 45
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be, be_nil
-# RSpec/BeNil:
-#   Exclude:
-#     - 'modules/appeals_api/spec/models/higher_level_review/phone_spec.rb'
-#     - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb'
-#     - 'modules/va_notify/spec/models/confirmation_email_spec.rb'
-#     - 'modules/vba_documents/spec/models/upload_submission_spec.rb'
-#     - 'modules/vba_documents/spec/sidekiq/upload_processor_spec.rb'
-#     - 'spec/controllers/v0/users_controller_spec.rb'
-#     - 'spec/lib/common/models/concerns/cache_aside_spec.rb'
-#     - 'spec/lib/evss/auth_headers_spec.rb'
-#     - 'spec/lib/evss/pciu/request_body_spec.rb'
-#     - 'spec/lib/facilities/drivetime_bands/response_spec.rb'
-#     - 'spec/lib/formatters/date_formatter_spec.rb'
-#     - 'spec/lib/identity/parsers/gc_ids_helper_spec.rb'
-#     - 'spec/lib/mpi/responses/parser_base_spec.rb'
-#     - 'spec/lib/pdf_fill/forms/form_helper_spec.rb'
-#     - 'spec/lib/sentry/scrubbers/filter_request_body_spec.rb'
-#     - 'spec/lib/sidekiq/form526_backup_submission_process/submit_spec.rb'
-#     - 'spec/models/education_benefits_claim_spec.rb'
-#     - 'spec/models/form526_submission_spec.rb'
-#     - 'spec/models/mpi_data_spec.rb'
-#     - 'spec/models/user_spec.rb'
-#     - 'spec/services/bgs/people/request_spec.rb'
-#     - 'spec/services/identity/account_creator_spec.rb'
-#     - 'spec/services/sign_in/attribute_validator_spec.rb'
-#     - 'spec/sidekiq/webhooks/callback_url_job_spec.rb'
-
-# Offense count: 11
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: NegatedMatcher.
-RSpec/ChangeByZero:
-  Exclude:
-    - 'spec/lib/flipper/instrumentation/event_subscriber_spec.rb'
-    - 'spec/lib/sidekiq/form526_backup_submission_process/submit_spec.rb'
-    - 'spec/models/form526_submission_spec.rb'
-    - 'spec/models/saved_claim/education_benefits/va10203_spec.rb'
-    - 'spec/sidekiq/in_progress_form_cleaner_spec.rb'
-
-# Offense count: 25
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be_a, be_kind_of
-RSpec/ClassCheck:
-  Exclude:
-    - 'spec/controllers/v0/virtual_agent/virtual_agent_appeal_spec.rb'
-    - 'spec/controllers/v0/virtual_agent/virtual_agent_claim_spec.rb'
-    - 'spec/lib/common/models/redis_store_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/session_manager_spec.rb'
-
-# Offense count: 17
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ExcessiveDocstringSpacing:
-  Exclude:
-    - 'modules/check_in/spec/services/v2/lorota/service_spec.rb'
-    - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb'
-    - 'modules/dhp_connected_devices/spec/services/dhp_connected_devices/token_storage_service_spec.rb'
-    - 'modules/va_forms/spec/lib/regex_helper_spec.rb'
-    - 'spec/controllers/v0/virtual_agent/virtual_agent_appeal_spec.rb'
-    - 'spec/lib/evss/disability_compensation_form/data_translation_all_claim_spec.rb'
-    - 'spec/lib/generators/module/module_generator_spec.rb'
-    - 'spec/mailers/veteran_readiness_employment_mailer_spec.rb'
-    - 'spec/models/facilities_query_spec.rb'
-    - 'spec/sidekiq/vre/create_ch31_submissions_report_job_spec.rb'
-
 # Offense count: 57
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
@@ -428,20 +355,6 @@ RSpec/PendingWithoutReason:
     - 'spec/requests/breakers_integration_spec.rb'
     - 'spec/sidekiq/facilities/mental_health_reload_job_spec.rb'
 
-# Offense count: 10
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/SortMetadata:
-  Exclude:
-    - 'spec/lib/sftp_writer/factory_spec.rb'
-    - 'spec/requests/authentication/standard_authentication_spec.rb'
-    - 'spec/requests/swagger_spec.rb'
-    - 'spec/sidekiq/education_form/create10203_applicant_decision_letters_spec.rb'
-    - 'spec/sidekiq/education_form/create_daily_spool_files_spec.rb'
-    - 'spec/sidekiq/education_form/forms/base_spec.rb'
-    - 'spec/sidekiq/education_form/forms/va1990_spec.rb'
-    - 'spec/sidekiq/education_form/process10203_submissions_spec.rb'
-    - 'spec/sidekiq/education_form/send_school_certifying_officials_email_spec.rb'
-
 # Offense count: 715
 RSpec/StubbedMock:
   Enabled: false
@@ -466,65 +379,6 @@ RSpec/SubjectDeclaration:
     - 'spec/sidekiq/pager_duty/cache_global_downtime_spec.rb'
     - 'spec/uploaders/form1010cg/poa_uploader_spec.rb'
 
-# Offense count: 91
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: constant, string
-RSpec/VerifiedDoubleReference:
-  Exclude:
-    - 'modules/appeals_api/spec/lib/health_checker_spec.rb'
-    - 'modules/appeals_api/spec/services/appeals_api/central_mail_updater_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/appeals_api/daily_error_report_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/appeals_api/monthly_stats_report_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/concerns/appeals_api/report_recipients_reader_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/decision_review_report_daily_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/decision_review_report_weekly_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/higher_level_review_upload_status_batch_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/higher_level_review_upload_status_updater_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/notice_of_disagreement_upload_status_batch_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/notice_of_disagreement_upload_status_updater_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/pdf_submit_job_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/supplemental_claim_upload_status_batch_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/supplemental_claim_upload_status_updater_spec.rb'
-    - 'modules/appeals_api/spec/support/shared_examples_for_monitored_worker.rb'
-    - 'modules/claims_api/spec/sidekiq/claim_establisher_spec.rb'
-    - 'modules/claims_api/spec/sidekiq/claim_uploader_spec.rb'
-    - 'modules/claims_api/spec/sidekiq/poa_vbms_updater_spec.rb'
-    - 'modules/vba_documents/spec/models/upload_submission_spec.rb'
-    - 'modules/vba_documents/spec/sidekiq/upload_processor_spec.rb'
-    - 'modules/vba_documents/spec/sidekiq/upload_status_batch_spec.rb'
-    - 'modules/vba_documents/spec/sidekiq/upload_status_updater_spec.rb'
-    - 'spec/controllers/v1/sessions_controller_spec.rb'
-    - 'spec/lib/common/client/middleware/request/soap_headers_spec.rb'
-    - 'spec/lib/evss/intent_to_file/response_strategy_spec.rb'
-    - 'spec/lib/evss/pciu_address/response_strategy_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/configuration_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/service_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/session_manager_spec.rb'
-    - 'spec/lib/mpi/configuration_spec.rb'
-    - 'spec/lib/mpi/responses/add_parser_spec.rb'
-    - 'spec/lib/mpi/responses/profile_parser_spec.rb'
-    - 'spec/lib/shrine/plugins/validate_unlocked_pdf_spec.rb'
-    - 'spec/lib/shrine/plugins/validate_virus_free_spec.rb'
-    - 'spec/models/facilities/vha_facility_spec.rb'
-    - 'spec/requests/swagger_spec.rb'
-    - 'spec/services/evss_claim_service_spec.rb'
-    - 'spec/services/mhv_account_type_service_spec.rb'
-    - 'spec/sidekiq/cypress_viewport_updater/update_cypress_viewports_job_spec.rb'
-    - 'spec/sidekiq/education_form/create_daily_spool_files_spec.rb'
-    - 'spec/sidekiq/evss/document_upload_spec.rb'
-    - 'spec/sidekiq/evss/request_decision_spec.rb'
-    - 'spec/sidekiq/evss/retrieve_claims_from_remote_job_spec.rb'
-    - 'spec/sidekiq/evss/update_claim_from_remote_job_spec.rb'
-    - 'spec/sidekiq/facilities/access_data_download_spec.rb'
-    - 'spec/sidekiq/facilities/facility_location_download_job_spec.rb'
-    - 'spec/sidekiq/facilities/pssg_download_spec.rb'
-    - 'spec/sidekiq/form526_confirmation_email_job_spec.rb'
-    - 'spec/sidekiq/pager_duty/cache_global_downtime_spec.rb'
-    - 'spec/sidekiq/pager_duty/poll_maintenance_windows_spec.rb'
-    - 'spec/sidekiq/webhooks/callback_url_job_spec.rb'
-    - 'spec/support/poa_stub.rb'
-
 # Offense count: 87
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: ResponseMethods.

modules/appeals_api/spec/lib/health_checker_spec.rb

@@ -12,7 +12,7 @@
     caseflow
   end
 
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:faraday_response) { instance_double(Faraday::Response) }
 
   describe '#appeals_services_are_healthy?' do
     context 'when caseflow is healthy' do

modules/appeals_api/spec/services/appeals_api/central_mail_updater_spec.rb

@@ -3,8 +3,8 @@
 require 'rails_helper'
 
 describe AppealsApi::CentralMailUpdater do
-  let(:client_stub) { instance_double('CentralMail::Service') }
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:client_stub) { instance_double(CentralMail::Service) }
+  let(:faraday_response) { instance_double(Faraday::Response) }
   let(:appeal_1) { create(:notice_of_disagreement) }
   let(:appeal_2) { create(:notice_of_disagreement) }
   let(:central_mail_response) do

modules/appeals_api/spec/sidekiq/appeals_api/daily_error_report_spec.rb

@@ -36,7 +36,7 @@
     end
 
     it 'notifies slack when there are no recipients' do
-      messager_instance = instance_double('AppealsApi::Slack::Messager')
+      messager_instance = instance_double(AppealsApi::Slack::Messager)
 
       allow(YAML).to receive(:load_file).and_return({})
       allow(AppealsApi::Slack::Messager).to receive(:new).and_return(messager_instance)

modules/appeals_api/spec/sidekiq/appeals_api/monthly_stats_report_spec.rb

@@ -21,7 +21,7 @@
 
       it 'does not build a report without recipients' do
         allow(YAML).to receive(:load_file).and_return({ 'common' => %w[] })
-        messager = instance_double('AppealsApi::Slack::Messager')
+        messager = instance_double(AppealsApi::Slack::Messager)
         allow(AppealsApi::Slack::Messager).to receive(:new).and_return(messager)
         expect(messager).to receive(:notify!)
         expect(AppealsApi::StatsReportMailer).not_to receive(:build)

modules/appeals_api/spec/sidekiq/concerns/appeals_api/report_recipients_reader_spec.rb

@@ -9,7 +9,7 @@
   describe 'load_recipients' do
     let(:recipient_file_folder) { AppealsApi::Engine.root.join('config', 'mailinglists') }
     let(:recipient_file_path) { recipient_file_folder.join('error_report_daily.yml').to_s }
-    let(:messager_instance) { instance_double('AppealsApi::Slack::Messager') }
+    let(:messager_instance) { instance_double(AppealsApi::Slack::Messager) }
 
     it 'loads no users when file is missing' do
       expected_notify = { warning: ':warning:  recipients file does not exist',

modules/appeals_api/spec/sidekiq/decision_review_report_daily_spec.rb

@@ -36,7 +36,7 @@
     end
 
     it 'does not send email when no recipients are received' do
-      messager_instance = instance_double('AppealsApi::Slack::Messager')
+      messager_instance = instance_double(AppealsApi::Slack::Messager)
       with_settings(Settings.modules_appeals_api.reports.daily_decision_review, enabled: true) do
         allow(YAML).to receive(:load_file).and_return({})
         allow(AppealsApi::Slack::Messager).to receive(:new).and_return(messager_instance)

modules/appeals_api/spec/sidekiq/decision_review_report_weekly_spec.rb

@@ -36,7 +36,7 @@
     end
 
     it 'does not send email when no recipients are received' do
-      messager_instance = instance_double('AppealsApi::Slack::Messager')
+      messager_instance = instance_double(AppealsApi::Slack::Messager)
       with_settings(Settings.modules_appeals_api.reports.weekly_decision_review, enabled: true) do
         allow(YAML).to receive(:load_file).and_return({})
         allow(AppealsApi::Slack::Messager).to receive(:new).and_return(messager_instance)

modules/appeals_api/spec/sidekiq/higher_level_review_upload_status_batch_spec.rb

@@ -3,10 +3,10 @@
 require 'rails_helper'
 
 describe AppealsApi::HigherLevelReviewUploadStatusBatch, type: :job do
-  let(:client_stub) { instance_double('CentralMail::Service') }
+  let(:client_stub) { instance_double(CentralMail::Service) }
   let(:upload) { create(:higher_level_review_v2, status: :submitted) }
   let!(:uploads) { [upload] }
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:faraday_response) { instance_double(Faraday::Response) }
   let(:cmp_status) { 'In Process' }
 
   describe '#perform' do

modules/appeals_api/spec/sidekiq/higher_level_review_upload_status_updater_spec.rb

@@ -4,9 +4,9 @@
 require AppealsApi::Engine.root.join('spec', 'support', 'shared_examples_for_monitored_worker.rb')
 
 describe AppealsApi::HigherLevelReviewUploadStatusUpdater, type: :job do
-  let(:client_stub) { instance_double('CentralMail::Service') }
+  let(:client_stub) { instance_double(CentralMail::Service) }
   let(:upload) { create(:higher_level_review_v2, status: 'submitting') }
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:faraday_response) { instance_double(Faraday::Response) }
   let(:in_process_element) do
     [{ uuid: 'ignored',
        status: 'In Process',

modules/appeals_api/spec/sidekiq/notice_of_disagreement_upload_status_batch_spec.rb

@@ -3,9 +3,9 @@
 require 'rails_helper'
 
 describe AppealsApi::NoticeOfDisagreementUploadStatusBatch, type: :job do
-  let(:client_stub) { instance_double('CentralMail::Service') }
+  let(:client_stub) { instance_double(CentralMail::Service) }
   let!(:upload) { create(:notice_of_disagreement, status: 'submitted') }
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:faraday_response) { instance_double(Faraday::Response) }
   let(:in_process_element) do
     [{ uuid: 'ignored',
        status: cmp_status,

modules/appeals_api/spec/sidekiq/notice_of_disagreement_upload_status_updater_spec.rb

@@ -4,9 +4,9 @@
 require AppealsApi::Engine.root.join('spec', 'support', 'shared_examples_for_monitored_worker.rb')
 
 describe AppealsApi::NoticeOfDisagreementUploadStatusUpdater, type: :job do
-  let(:client_stub) { instance_double('CentralMail::Service') }
+  let(:client_stub) { instance_double(CentralMail::Service) }
   let(:upload) { create(:notice_of_disagreement, status: 'submitted') }
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:faraday_response) { instance_double(Faraday::Response) }
   let(:in_process_element) do
     [{ uuid: 'ignored',
        status: 'In Process',

modules/appeals_api/spec/sidekiq/pdf_submit_job_spec.rb

@@ -18,15 +18,15 @@
   let(:higher_level_review) { create(:higher_level_review_v2) }
   let(:notice_of_disagreement) { create(:notice_of_disagreement) }
   let(:supplemental_claim) { create(:supplemental_claim) }
-  let(:client_stub) { instance_double('CentralMail::Service') }
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:client_stub) { instance_double(CentralMail::Service) }
+  let(:faraday_response) { instance_double(Faraday::Response) }
 
   it_behaves_like 'a monitored worker'
 
   describe 'uploads a valid payload' do
     it 'HLRv2' do
       Timecop.freeze(DateTime.new(2020, 1, 1).utc) do
-        file_digest_stub = instance_double('Digest::SHA256')
+        file_digest_stub = instance_double(Digest::SHA256)
         allow(Digest::SHA256).to receive(:file) { file_digest_stub }
         allow(file_digest_stub).to receive(:hexdigest).and_return('file_digest_12345')
 
@@ -68,7 +68,7 @@
     it 'NOD' do
       Timecop.freeze(DateTime.new(2020, 1, 1).utc) do
         allow(CentralMail::Service).to receive(:new) { client_stub }
-        file_digest_stub = instance_double('Digest::SHA256')
+        file_digest_stub = instance_double(Digest::SHA256)
         allow(Digest::SHA256).to receive(:file) { file_digest_stub }
         allow(file_digest_stub).to receive(:hexdigest).and_return('file_digest_12345')
 
@@ -110,7 +110,7 @@
 
     it 'SC' do
       Timecop.freeze(DateTime.new(2020, 1, 1).utc) do
-        file_digest_stub = instance_double('Digest::SHA256')
+        file_digest_stub = instance_double(Digest::SHA256)
         allow(Digest::SHA256).to receive(:file) { file_digest_stub }
         allow(file_digest_stub).to receive(:hexdigest).and_return('file_digest_12345')
 

modules/appeals_api/spec/sidekiq/supplemental_claim_upload_status_batch_spec.rb

@@ -3,9 +3,9 @@
 require 'rails_helper'
 
 describe AppealsApi::SupplementalClaimUploadStatusBatch, type: :job do
-  let(:client_stub) { instance_double('CentralMail::Service') }
+  let(:client_stub) { instance_double(CentralMail::Service) }
   let!(:upload) { create(:supplemental_claim, :status_submitted) }
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:faraday_response) { instance_double(Faraday::Response) }
   let(:in_process_element) do
     [{ uuid: 'ignored',
        status: 'In Process',

modules/appeals_api/spec/sidekiq/supplemental_claim_upload_status_updater_spec.rb

@@ -4,9 +4,9 @@
 require AppealsApi::Engine.root.join('spec', 'support', 'shared_examples_for_monitored_worker.rb')
 
 describe AppealsApi::SupplementalClaimUploadStatusUpdater, type: :job do
-  let(:client_stub) { instance_double('CentralMail::Service') }
+  let(:client_stub) { instance_double(CentralMail::Service) }
   let(:upload) { create(:supplemental_claim, :status_submitted) }
-  let(:faraday_response) { instance_double('Faraday::Response') }
+  let(:faraday_response) { instance_double(Faraday::Response) }
   let(:in_process_element) do
     [{ uuid: 'ignored',
        status: 'In Process',

modules/appeals_api/spec/support/shared_examples_for_monitored_worker.rb

@@ -19,7 +19,7 @@
   end
 
   it 'calls SidekiqRetryNotifer' do
-    messager_instance = instance_double('AppealsApi::Slack::Messager')
+    messager_instance = instance_double(AppealsApi::Slack::Messager)
     allow(AppealsApi::Slack::Messager).to receive(:new).and_return(messager_instance)
     allow(messager_instance).to receive(:notify!)
     described_class.new.notify({})

modules/check_in/spec/services/v2/lorota/service_spec.rb

@@ -644,7 +644,7 @@
         end
       end
 
-      context 'when status code is 400 with internal service exception from downstream ' do
+      context 'when status code is 400 with internal service exception from downstream' do
         let(:internal_service_exception) do
           { status: 400, detail: 'Internal Error', code: 'VA900' }
         end