Remove danger from CI rake task (#3510)

department-of-veterans-affairs · Nov 6, 2019 · 8485bfb · 8485bfb
1 parent 358afb0
commit 8485bfb
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 29 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -28,10 +28,7 @@ pipeline {
 
     stage('Run tests') {
       steps {
-        withCredentials([
-          string(credentialsId: 'sidekiq-enterprise-license', variable: 'BUNDLE_ENTERPRISE__CONTRIBSYS__COM'),
-          string(credentialsId: 'danger-github-api-token',    variable: 'DANGER_GITHUB_API_TOKEN')
-        ]) {
+        withCredentials([string(credentialsId: 'sidekiq-enterprise-license', variable: 'BUNDLE_ENTERPRISE__CONTRIBSYS__COM')]) {
           withEnv(['RAILS_ENV=test', 'CI=true']) {
             sh 'make ci'
           }
@@ -46,6 +43,14 @@ pipeline {
       }
     }
 
+    stage('Run Danger Bot') {
+      steps {
+        withCredentials([string(credentialsId: 'danger-github-api-token',    variable: 'DANGER_GITHUB_API_TOKEN')]) {
+          sh 'make danger'
+        }
+      }
+    }
+
     stage('Review') {
       when { not { branch 'master' } }
 

diff --git a/Makefile b/Makefile
@@ -26,6 +26,10 @@ clean:
 console:
 	@$(BASH_DEV) "bundle exec rails c"
 
+.PHONY: danger
+danger:
+	@$(BASH_TEST) "bundle exec danger --verbose"
+
 .PHONY: db
 db:
 	@$(BASH_DEV) "bin/rails db:setup db:migrate"

diff --git a/rakelib/ci.rake b/rakelib/ci.rake
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 desc 'Runs the continuous integration scripts'
-task ci: %i[lint security danger spec:with_codeclimate_coverage]
+task ci: %i[lint security spec:with_codeclimate_coverage]
 
 task default: :ci
 

diff --git a/rakelib/danger.rake b/rakelib/danger.rake