run 'rubocop --auto-gen-config --exclude-limit 100' (#15534)

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 100`
-# on 2024-02-01 22:07:02 UTC using RuboCop version 1.60.2.
+# on 2024-02-14 15:39:17 UTC using RuboCop version 1.60.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -83,7 +83,7 @@ FactoryBot/ConsistentParenthesesStyle:
     - 'spec/sidekiq/form1095/new1095_bs_job_spec.rb'
     - 'spec/sidekiq/vre/create_ch31_submissions_report_job_spec.rb'
 
-# Offense count: 480
+# Offense count: 489
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Include.
 # Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
@@ -181,7 +181,7 @@ Lint/AmbiguousRange:
     - 'modules/claims_api/app/uploaders/claims_api/base_uploader.rb'
     - 'spec/uploaders/form1010cg/poa_uploader_spec.rb'
 
-# Offense count: 80
+# Offense count: 81
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: enums
 Lint/ConstantDefinitionInBlock:
@@ -471,7 +471,7 @@ Lint/UselessRescue:
     - 'app/controllers/v0/contact_us/inquiries_controller.rb'
     - 'lib/lgy/service.rb'
 
-# Offense count: 891
+# Offense count: 888
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 90
@@ -482,17 +482,17 @@ Metrics/AbcSize:
 Metrics/BlockLength:
   Max: 62
 
-# Offense count: 183
+# Offense count: 188
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 29
 
-# Offense count: 125
+# Offense count: 128
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 29
 
-# Offense count: 238
+# Offense count: 265
 Naming/AccessorMethodName:
   Enabled: false
 
@@ -587,7 +587,7 @@ Naming/VariableNumber:
     - 'spec/sidekiq/facilities/state_cemetery_reload_job_spec.rb'
     - 'spec/sidekiq/form1010cg/delete_old_uploads_job_spec.rb'
 
-# Offense count: 893
+# Offense count: 905
 # This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/BeEq:
   Enabled: false
@@ -695,7 +695,7 @@ RSpec/ExcessiveDocstringSpacing:
     - 'spec/requests/upload_supporting_evidence_request_spec.rb'
     - 'spec/sidekiq/vre/create_ch31_submissions_report_job_spec.rb'
 
-# Offense count: 65
+# Offense count: 66
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
 RSpec/NoExpectationExample:
@@ -756,7 +756,7 @@ RSpec/PendingWithoutReason:
     - 'spec/requests/breakers_integration_spec.rb'
     - 'spec/sidekiq/facilities/mental_health_reload_job_spec.rb'
 
-# Offense count: 599
+# Offense count: 603
 # This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/Rails/HaveHttpStatus:
   Exclude:
@@ -841,7 +841,7 @@ RSpec/Rails/HaveHttpStatus:
     - 'spec/support/controller_spec_helper.rb'
     - 'spec/support/shared_examples_for_mhv.rb'
 
-# Offense count: 256
+# Offense count: 259
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Inferences.
 RSpec/Rails/InferredSpecType:
@@ -878,7 +878,7 @@ RSpec/SortMetadata:
     - 'spec/sidekiq/education_form/process10203_submissions_spec.rb'
     - 'spec/sidekiq/education_form/send_school_certifying_officials_email_spec.rb'
 
-# Offense count: 666
+# Offense count: 650
 RSpec/StubbedMock:
   Enabled: false
 
@@ -911,7 +911,7 @@ RSpec/SubjectDeclaration:
     - 'spec/sidekiq/sidekiq_alive/cleanup_queues_spec.rb'
     - 'spec/uploaders/form1010cg/poa_uploader_spec.rb'
 
-# Offense count: 124
+# Offense count: 123
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: constant, string
@@ -951,7 +951,6 @@ RSpec/VerifiedDoubleReference:
     - 'spec/controllers/v0/financial_status_reports_controller_spec.rb'
     - 'spec/controllers/v1/sessions_controller_spec.rb'
     - 'spec/lib/common/client/middleware/request/soap_headers_spec.rb'
-    - 'spec/lib/emis/responses/get_combat_pay_response_spec.rb'
     - 'spec/lib/emis/responses/get_deployment_response_spec.rb'
     - 'spec/lib/emis/responses/get_disabilities_response_spec.rb'
     - 'spec/lib/emis/responses/get_guard_reserve_service_periods_response_spec.rb'
@@ -1087,7 +1086,7 @@ Rails/FilePath:
     - 'modules/dhp_connected_devices/app/services/token_storage_service.rb'
     - 'spec/sidekiq/evss/document_upload_spec.rb'
 
-# Offense count: 16
+# Offense count: 15
 Rails/I18nLocaleTexts:
   Exclude:
     - 'app/mailers/failed_claims_report_mailer.rb'
@@ -1146,7 +1145,7 @@ Rails/RedundantPresenceValidationOnBelongsTo:
     - 'modules/claims_api/app/models/claims_api/supporting_document.rb'
     - 'modules/dhp_connected_devices/app/models/veteran_device_record.rb'
 
-# Offense count: 147
+# Offense count: 152
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/RootPathnameMethods:
   Exclude:
@@ -1301,7 +1300,7 @@ Style/NegatedIfElseCondition:
     - 'modules/dhp_connected_devices/app/serializers/device_serializer.rb'
     - 'modules/vaos/app/controllers/vaos/v2/appointments_controller.rb'
 
-# Offense count: 374
+# Offense count: 368
 Style/OpenStructUse:
   Enabled: false
 
@@ -1362,7 +1361,7 @@ Style/RedundantArgument:
     - 'modules/appeals_api/spec/support/pdf_matcher.rb'
     - 'modules/mobile/app/models/mobile/v0/adapters/vaos_v2_appointment.rb'
 
-# Offense count: 139
+# Offense count: 140
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantConstantBase:
   Exclude: