Switch Settings.dig to dot notation (#19099)

* switch Settings.dig to dot notation

* fix linting warning

* add nod_vanotify_status_callback and pension_ipf_vanotify_status_callback bearer_tokens to setting.yml

app/controllers/v1/nod_callbacks_controller.rb

@@ -95,7 +95,7 @@ def authenticity_error
     end
 
     def bearer_token_secret
-      Settings.dig(:nod_vanotify_status_callback, :bearer_token)
+      Settings.nod_vanotify_status_callback.bearer_token
     end
 
     def enabled?

app/controllers/v1/pension_ipf_callbacks_controller.rb

@@ -63,7 +63,7 @@ def authenticity_error
     end
 
     def bearer_token_secret
-      Settings.dig(:pension_ipf_vanotify_status_callback, :bearer_token)
+      Settings.pension_ipf_vanotify_status_callback.bearer_token
     end
 
     def log_params(payload)

config/settings.yml

@@ -1751,6 +1751,12 @@ brd:
   api_key: 'fake_key'
   base_name: 'https://something.fake.va.gov'
 
+nod_vanotify_status_callback:
+  bearer_token: bearer_token_secret
+
+pension_ipf_vanotify_status_callback:
+  bearer_token: bearer_token_secret
+
 travel_pay:
   sts:
     service_account_id: ~

modules/appeals_api/app/controllers/appeals_api/appealable_issues/v0/appealable_issues_controller.rb

@@ -41,7 +41,7 @@ def validate_json_schema
 
     def token_validation_api_key
       # FIXME: rename token storage key
-      Settings.dig(:modules_appeals_api, :token_validation, :contestable_issues, :api_key)
+      Settings.modules_appeals_api.token_validation.contestable_issues.api_key
     end
 
     def get_caseflow_response

modules/appeals_api/app/controllers/appeals_api/higher_level_reviews/v0/higher_level_reviews_controller.rb

@@ -128,7 +128,7 @@ def render_model_errors(hlr)
     end
 
     def token_validation_api_key
-      Settings.dig(:modules_appeals_api, :token_validation, :higher_level_reviews, :api_key)
+      Settings.modules_appeals_api.token_validation.higher_level_reviews.api_key
     end
   end
 end

modules/appeals_api/app/controllers/appeals_api/legacy_appeals/v0/legacy_appeals_controller.rb

@@ -38,7 +38,7 @@ def get_caseflow_response
     end
 
     def token_validation_api_key
-      Settings.dig(:modules_appeals_api, :token_validation, :legacy_appeals, :api_key)
+      Settings.modules_appeals_api.token_validation.legacy_appeals.api_key
     end
   end
 end

modules/appeals_api/app/controllers/appeals_api/notice_of_disagreements/v0/notice_of_disagreements/evidence_submissions_controller.rb

@@ -77,7 +77,7 @@ def validate_token_nod_access!(nod_id)
     end
 
     def token_validation_api_key
-      Settings.dig(:modules_appeals_api, :token_validation, :notice_of_disagreements, :api_key)
+      Settings.modules_appeals_api.token_validation.notice_of_disagreements.api_key
     end
   end
 end

modules/appeals_api/app/controllers/appeals_api/notice_of_disagreements/v0/notice_of_disagreements_controller.rb

@@ -128,7 +128,7 @@ def request_headers
     end
 
     def token_validation_api_key
-      Settings.dig(:modules_appeals_api, :token_validation, :notice_of_disagreements, :api_key)
+      Settings.modules_appeals_api.token_validation.notice_of_disagreements.api_key
     end
   end
 end

modules/appeals_api/app/controllers/appeals_api/supplemental_claims/v0/supplemental_claims/evidence_submissions_controller.rb

@@ -77,7 +77,7 @@ def validate_token_sc_access!(sc_id)
     end
 
     def token_validation_api_key
-      Settings.dig(:modules_appeals_api, :token_validation, :supplemental_claims, :api_key)
+      Settings.modules_appeals_api.token_validation.supplemental_claims.api_key
     end
   end
 end

modules/appeals_api/app/controllers/appeals_api/supplemental_claims/v0/supplemental_claims_controller.rb

@@ -127,7 +127,7 @@ def render_model_errors(model)
     end
 
     def token_validation_api_key
-      Settings.dig(:modules_appeals_api, :token_validation, :supplemental_claims, :api_key)
+      Settings.modules_appeals_api.token_validation.supplemental_claims.api_key
     end
   end
 end

modules/appeals_api/app/controllers/appeals_api/v1/appeals_controller.rb

@@ -36,7 +36,7 @@ def get_caseflow_response
       end
 
       def token_validation_api_key
-        Settings.dig(:modules_appeals_api, :token_validation, :appeals_status, :api_key)
+        Settings.modules_appeals_api.token_validation.appeals_status.api_key
       end
     end
   end

modules/appeals_api/app/controllers/concerns/appeals_api/openid_auth.rb

@@ -64,7 +64,7 @@ def token_validation_result
     private
 
     def unsafe_mode?
-      Rails.env.development? && Settings.dig(:modules_appeals_api, :enable_unsafe_mode)
+      Rails.env.development? && Settings.modules_appeals_api.enable_unsafe_mode
     end
 
     # Override this in individual controllers

modules/covid_vaccine/app/sidekiq/covid_vaccine/scheduled_batch_job.rb

@@ -32,7 +32,7 @@ def perform
     private
 
     def enrollment_upload_enabled?
-      Settings.dig('covid_vaccine', 'enrollment_service', 'job_enabled')
+      Settings.covid_vaccine.enrollment_service.job_enabled
     end
 
     def handle_errors(ex)