Change name/symbol of custom RaiseError class (#17024)

* Change name/symbol of custom RaiseError class * change require path + a couple I missed * add to codeowners * Add ClaimsApi changes * fix codeowners * change naming scheme
department-of-veterans-affairs · Jun 7, 2024 · 045d864 · 045d864
1 parent 18a8567
commit 045d864
Show file tree

Hide file tree

Showing 53 changed files with 80 additions and 80 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -832,10 +832,10 @@ lib/common/client/concerns/mhv_fhir_session_client.rb @department-of-veterans-af
 lib/common/client/concerns/mhv_jwt_session_client.rb @department-of-veterans-affairs/vfs-mhv-medical-records @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 lib/common/client/concerns/mhv_locked_session_client.rb @department-of-veterans-affairs/vfs-mhv-medical-records @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 lib/common/client/concerns/mhv_session_based_client.rb @department-of-veterans-affairs/vfs-mhv-medications @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-lib/common/client/configuration/base.rb @department-of-veterans-affairs/backend-review-group
+lib/common/client/configuration @department-of-veterans-affairs/backend-review-group
 lib/common/client/middleware/request/multipart_request.rb @department-of-veterans-affairs/backend-review-group
 lib/common/client/middleware/request/remove_cookies.rb @department-of-veterans-affairs/backend-review-group
-lib/common/client/middleware/response/soap_parser.rb @department-of-veterans-affairs/backend-review-group
+lib/common/client/middleware/response @department-of-veterans-affairs/backend-review-group
 lib/common/exceptions/open_id_service_error.rb @department-of-veterans-affairs/lighthouse-pivot
 lib/common/file_helpers.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 lib/common/pdf_helpers.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group

diff --git a/app/services/medical_copays/request.rb b/app/services/medical_copays/request.rb
@@ -75,7 +75,7 @@ def connection
         conn.request :json
         conn.use :breakers
         conn.use Faraday::Response::RaiseError
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :json
         conn.response :betamocks if mock_enabled?
         conn.adapter Faraday.default_adapter

diff --git a/docs/setup/betamocks.md b/docs/setup/betamocks.md
@@ -42,7 +42,7 @@ def connection
     conn.use :breakers
     conn.request :json
     
-    conn.response :raise_error, error_prefix: service_name
+    conn.response :raise_custom_error, error_prefix: service_name
     conn.response :facility_parser
     conn.response :facility_validator
     conn.response :betamocks if Settings.locators.mock_gis

diff --git a/lib/bb/configuration.rb b/lib/bb/configuration.rb
@@ -3,7 +3,7 @@
 require 'common/client/configuration/rest'
 require 'common/client/middleware/request/camelcase'
 require 'common/client/middleware/response/json_parser'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/mhv_errors'
 require 'common/client/middleware/response/snakecase'
 require 'common/client/middleware/response/mhv_xml_html_errors'
@@ -62,7 +62,7 @@ def connection
         conn.response :betamocks if Settings.mhv.bb.mock
         conn.response :bb_parser
         conn.response :snakecase
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :mhv_errors
         conn.response :mhv_xml_html_errors
         conn.response :json_parser

diff --git a/lib/bip_claims/configuration.rb b/lib/bip_claims/configuration.rb
@@ -20,7 +20,7 @@ def connection
         faraday.use :breakers
         faraday.request :json
 
-        faraday.response :raise_error, error_prefix: service_name
+        faraday.response :raise_custom_error, error_prefix: service_name
         faraday.response :betamocks if mock_enabled?
         faraday.response :json
         faraday.adapter Faraday.default_adapter

diff --git a/lib/caseflow/configuration.rb b/lib/caseflow/configuration.rb
@@ -2,7 +2,7 @@
 
 require 'common/client/middleware/response/caseflow_errors'
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 
 module Caseflow
   ##
@@ -42,7 +42,7 @@ def connection
         faraday.use :breakers
         faraday.request :json
 
-        faraday.response :raise_error, error_prefix: service_name
+        faraday.response :raise_custom_error, error_prefix: service_name
         faraday.response :caseflow_errors
         faraday.response :betamocks if mock_enabled?
         faraday.response :json

diff --git a/lib/common/client/configuration/rest.rb b/lib/common/client/configuration/rest.rb
@@ -23,7 +23,7 @@ module Configuration
       #         faraday.use :breakers
       #         faraday.request :json
       #
-      #         faraday.response :raise_error, error_prefix: service_name
+      #         faraday.response :raise_custom_error, error_prefix: service_name
       #         faraday.response :betamocks if mock_enabled?
       #         faraday.response :json
       #         faraday.adapter Faraday.default_adapter

diff --git a/...client/middleware/response/raise_error.rb → ...middleware/response/raise_custom_error.rb b/...client/middleware/response/raise_error.rb → ...middleware/response/raise_custom_error.rb
@@ -6,7 +6,7 @@ module Middleware
       module Response
         class BackendUnhandledException < StandardError; end
 
-        class RaiseError < Faraday::Middleware
+        class RaiseCustomError < Faraday::Middleware
           attr_reader :error_prefix, :body, :status
 
           def initialize(app, options = {})
@@ -55,4 +55,4 @@ def response_values
   end
 end
 
-Faraday::Response.register_middleware raise_error: Common::Client::Middleware::Response::RaiseError
+Faraday::Response.register_middleware raise_custom_error: Common::Client::Middleware::Response::RaiseCustomError
diff --git a/lib/debt_management_center/sharepoint/request.rb b/lib/debt_management_center/sharepoint/request.rb
@@ -169,7 +169,7 @@ def auth_connection
           conn.request :url_encoded
           conn.use :breakers
           conn.use Faraday::Response::RaiseError
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
           conn.response :json
           conn.response :betamocks if mock_enabled?
           conn.adapter Faraday.default_adapter
@@ -181,7 +181,7 @@ def sharepoint_connection
           conn.request :json
           conn.use :breakers
           conn.use Faraday::Response::RaiseError
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
           conn.response :json
           conn.response :betamocks if mock_enabled?
           conn.adapter Faraday.default_adapter
@@ -194,7 +194,7 @@ def sharepoint_file_connection
           conn.request :url_encoded
           conn.use :breakers
           conn.use Faraday::Response::RaiseError
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
           conn.response :json
           conn.response :betamocks if mock_enabled?
           conn.adapter Faraday.default_adapter

diff --git a/lib/debt_management_center/vbs/request.rb b/lib/debt_management_center/vbs/request.rb
@@ -62,7 +62,7 @@ def connection
           conn.request :json
           conn.use :breakers
           conn.use Faraday::Response::RaiseError
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
           conn.response :json
           conn.response :betamocks if mock_enabled?
           conn.adapter Faraday.default_adapter

diff --git a/lib/facilities/bulk_configuration.rb b/lib/facilities/bulk_configuration.rb
@@ -2,7 +2,7 @@
 
 require 'common/client/configuration/rest'
 require 'common/client/middleware/response/json_parser'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 
 module Facilities
   class BulkJSONConfiguration < Common::Client::Configuration::REST
@@ -11,7 +11,7 @@ def connection
         conn.use :breakers
         conn.request :json
 
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :json_parser
 
         conn.adapter Faraday.default_adapter

diff --git a/lib/facilities/configuration.rb b/lib/facilities/configuration.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/facility_validator'
 require 'common/client/middleware/response/facility_parser'
 
@@ -24,7 +24,7 @@ def connection
         # conn.request(:curl, ::Logger.new(STDOUT), :warn) unless Rails.env.production?
         # conn.response(:logger, ::Logger.new(STDOUT), bodies: true) unless Rails.env.production?
 
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :facility_parser
         conn.response :facility_validator
 

diff --git a/lib/facilities/drivetime_bands/configuration.rb b/lib/facilities/drivetime_bands/configuration.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 
 module Facilities
   module DrivetimeBands
@@ -19,7 +19,7 @@ def connection
           conn.use :breakers
           conn.request :json
 
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
           conn.response :betamocks if Settings.locators.mock_gis
 
           conn.adapter Faraday.default_adapter

diff --git a/lib/facilities/gis/configuration.rb b/lib/facilities/gis/configuration.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/facility_validator'
 require 'common/client/middleware/response/facility_parser'
 
@@ -21,7 +21,7 @@ def connection
           conn.use :breakers
           conn.request :json
 
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
           conn.response :facility_parser
           conn.response :facility_validator
           conn.response :betamocks if Settings.locators.mock_gis

diff --git a/lib/facilities/gis/metadata_configuration.rb b/lib/facilities/gis/metadata_configuration.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/facility_parser'
 
 module Facilities
@@ -22,7 +22,7 @@ def connection
           conn.request :json
 
           conn.response :betamocks if Settings.locators.mock_gis
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
 
           conn.adapter Faraday.default_adapter
         end

diff --git a/lib/facilities/metadata/configuration.rb b/lib/facilities/metadata/configuration.rb
@@ -16,7 +16,7 @@ def connection
         Faraday.new(base_path, headers: base_request_headers, request: request_options) do |conn|
           conn.use :breakers
           conn.request :json
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
           conn.adapter Faraday.default_adapter
         end
       end

diff --git a/lib/gi/configuration.rb b/lib/gi/configuration.rb
@@ -3,7 +3,7 @@
 require 'common/client/configuration/rest'
 require 'common/client/middleware/response/gids_errors'
 require 'common/client/middleware/response/json_parser'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/snakecase'
 
 module GI
@@ -28,7 +28,7 @@ def connection
 
         # conn.response :logger, ::Logger.new(STDOUT), bodies: true
         conn.response :snakecase
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :gids_errors
         conn.response :json_parser
 

diff --git a/lib/lighthouse/facilities/configuration.rb b/lib/lighthouse/facilities/configuration.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'lighthouse/facilities/middleware/errors'
 
 module Lighthouse
@@ -28,7 +28,7 @@ def connection
           # conn.request(:curl, ::Logger.new(STDOUT), :warn) unless Rails.env.production?
           # conn.response(:logger, ::Logger.new(STDOUT), bodies: true) unless Rails.env.production?
 
-          conn.response :raise_error, error_prefix: service_name
+          conn.response :raise_custom_error, error_prefix: service_name
           conn.response :lighthouse_facilities_errors
 
           conn.adapter Faraday.default_adapter

diff --git a/lib/lighthouse/letters_generator/configuration.rb b/lib/lighthouse/letters_generator/configuration.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'lighthouse/auth/client_credentials/jwt_generator'
 require 'lighthouse/auth/client_credentials/service'
 

diff --git a/lib/lighthouse/veterans_health/configuration.rb b/lib/lighthouse/veterans_health/configuration.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 
 module Lighthouse
   module VeteransHealth

diff --git a/lib/mail_automation/configuration.rb b/lib/mail_automation/configuration.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'common/client/configuration/rest'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 
 module MailAutomation
   class Configuration < Common::Client::Configuration::REST

diff --git a/lib/medical_records/configuration.rb b/lib/medical_records/configuration.rb
@@ -4,7 +4,7 @@
 require 'common/client/middleware/request/camelcase'
 require 'common/client/middleware/request/multipart_request'
 require 'common/client/middleware/response/json_parser'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/mhv_errors'
 require 'common/client/middleware/response/snakecase'
 require 'faraday/multipart'
@@ -54,7 +54,7 @@ def connection
 
         # conn.response :betamocks if Settings.mhv.sm.mock
         conn.response :snakecase
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :mhv_errors
         conn.response :mhv_xml_html_errors
         conn.response :json_parser

diff --git a/lib/medical_records/phr_mgr/configuration.rb b/lib/medical_records/phr_mgr/configuration.rb
@@ -4,7 +4,7 @@
 require 'common/client/middleware/request/camelcase'
 require 'common/client/middleware/request/multipart_request'
 require 'common/client/middleware/response/json_parser'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/mhv_errors'
 require 'common/client/middleware/response/snakecase'
 require 'faraday/multipart'
@@ -52,7 +52,7 @@ def connection
         # conn.request(:curl, ::Logger.new(STDOUT), :warn) unless Rails.env.production?
         # conn.response(:logger, ::Logger.new(STDOUT), bodies: true) unless Rails.env.production?
 
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :mhv_errors
         conn.response :mhv_xml_html_errors
         conn.response :json_parser

diff --git a/lib/mhv_ac/configuration.rb b/lib/mhv_ac/configuration.rb
@@ -3,7 +3,7 @@
 require 'common/client/configuration/rest'
 require 'common/client/middleware/request/camelcase'
 require 'common/client/middleware/response/json_parser'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/mhv_errors'
 require 'common/client/middleware/response/mhv_xml_html_errors'
 require 'common/client/middleware/response/snakecase'
@@ -52,7 +52,7 @@ def connection
         # conn.response(:logger, ::Logger.new(STDOUT), bodies: true) unless Rails.env.production?
 
         conn.response :snakecase
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :mhv_errors
         conn.response :mhv_xml_html_errors
         conn.response :json_parser

diff --git a/lib/mhv_logging/client.rb b/lib/mhv_logging/client.rb
@@ -60,7 +60,7 @@ def connection
           # conn.response(:logger, ::Logger.new(STDOUT), bodies: true) unless Rails.env.production?
 
           conn.response :snakecase
-          conn.response :raise_error, error_prefix: 'MHV'
+          conn.response :raise_custom_error, error_prefix: 'MHV'
           conn.response :mhv_errors
           conn.response :mhv_xml_html_errors
           conn.response :json_parser

diff --git a/lib/pagerduty/configuration.rb b/lib/pagerduty/configuration.rb
@@ -2,7 +2,7 @@
 
 require 'common/client/configuration/rest'
 require 'common/client/middleware/response/json_parser'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 
 module PagerDuty
   class Configuration < Common::Client::Configuration::REST
@@ -11,7 +11,7 @@ def connection
         conn.use :breakers
         conn.request :json
 
-        conn.response :raise_error, error_prefix: service_name
+        conn.response :raise_custom_error, error_prefix: service_name
         conn.response :json_parser
 
         conn.adapter Faraday.default_adapter

diff --git a/lib/rx/configuration.rb b/lib/rx/configuration.rb
@@ -3,7 +3,7 @@
 require 'common/client/configuration/rest'
 require 'common/client/middleware/request/camelcase'
 require 'common/client/middleware/response/json_parser'
-require 'common/client/middleware/response/raise_error'
+require 'common/client/middleware/response/raise_custom_error'
 require 'common/client/middleware/response/mhv_errors'
 require 'common/client/middleware/response/snakecase'
 require 'common/client/middleware/response/mhv_xml_html_errors'