Bump rubocop from 1.45.1 to 1.53.0 (#13079)

* Bump rubocop from 1.45.1 to 1.53.0

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.45.1 to 1.53.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.45.1...v1.53.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* update todo

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil <ryan.mcneil@oddball.io>

.rubocop_todo.yml

@@ -1,12 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 100`
-# on 2023-06-22 17:27:31 UTC using RuboCop version 1.45.1.
+# on 2023-06-26 16:08:27 UTC using RuboCop version 1.53.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 190
+# Offense count: 189
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ExplicitOnly.
 # SupportedStyles: require_parentheses, omit_parentheses
@@ -97,9 +97,15 @@ FactoryBot/CreateList:
 FactoryBot/SyntaxMethods:
   Enabled: false
 
-# Offense count: 213
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
+  Exclude:
+    - 'spec/controllers/v0/virtual_agent/virtual_agent_claim_spec.rb'
+
+# Offense count: 212
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: space, no_space
 Layout/LineContinuationSpacing:
   Exclude:
@@ -114,7 +120,6 @@ Layout/LineContinuationSpacing:
     - 'lib/generators/module_component/module_component_generator.rb'
     - 'modules/appeals_api/app/swagger/appeals_api/v1/notice_of_disagreements_controller_swagger.rb'
     - 'modules/appeals_api/spec/docs/decision_reviews/higher_level_reviews_spec.rb'
-    - 'modules/appeals_api/spec/models/supplemental_claim_spec.rb'
     - 'modules/appeals_api/spec/requests/v2/supplemental_claims_controller_spec.rb'
     - 'modules/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb'
     - 'modules/claims_api/app/controllers/concerns/claims_api/poa_verification.rb'
@@ -258,7 +263,8 @@ Lint/DuplicateRegexpCharacterClassElement:
   Exclude:
     - 'modules/check_in/lib/check_in/utils/logger.rb'
 
-# Offense count: 102
+# Offense count: 93
+# Configuration parameters: AllowedParentClasses.
 Lint/MissingSuper:
   Exclude:
     - 'app/models/bgs_dependents/adult_child_attending_school.rb'
@@ -352,7 +358,6 @@ Lint/MissingSuper:
     - 'modules/va_notify/lib/va_notify/service.rb'
     - 'modules/vaos/app/services/vaos/session_service.rb'
     - 'modules/veteran/app/models/veteran/user.rb'
-    - 'spec/lib/carma/models/base_spec.rb'
 
 # Offense count: 8
 Lint/NoReturnInBeginEndBlocks:
@@ -385,6 +390,15 @@ Lint/OrAssignmentToConstant:
     - 'modules/appeals_api/app/controllers/concerns/appeals_api/header_modification.rb'
     - 'modules/claims_api/app/controllers/concerns/claims_api/endpoint_deprecation.rb'
 
+# Offense count: 16
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'modules/mobile/lib/scripts/appointments_list_validation.rb'
+    - 'rakelib/form526.rake'
+    - 'rakelib/mvi.rake'
+    - 'rakelib/vet360.rake'
+
 # Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowedMethods.
@@ -395,6 +409,12 @@ Lint/RedundantSafeNavigation:
     - 'modules/claims_api/lib/evss_service/token.rb'
     - 'modules/covid_vaccine/app/services/covid_vaccine/v0/facility_resolver.rb'
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantStringCoercion:
+  Exclude:
+    - 'rakelib/form526.rake'
+
 # Offense count: 1
 Lint/RequireRangeParentheses:
   Exclude:
@@ -467,7 +487,7 @@ Lint/UselessRescue:
     - 'app/workers/structured_data/process_data_job.rb'
     - 'lib/lgy/service.rb'
 
-# Offense count: 755
+# Offense count: 756
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 90
@@ -491,7 +511,7 @@ Metrics/PerceivedComplexity:
 # Offense count: 273
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
-# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
 Naming/VariableNumber:
   Exclude:
     - 'app/controllers/v1/supplemental_claims_controller.rb'
@@ -583,7 +603,7 @@ Naming/VariableNumber:
     - 'spec/services/form1010cg/service_spec.rb'
     - 'spec/services/sign_in/revoke_sessions_for_user_spec.rb'
 
-# Offense count: 814
+# Offense count: 818
 # This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/BeEq:
   Enabled: false
@@ -1166,7 +1186,7 @@ Rails/RedundantPresenceValidationOnBelongsTo:
     - 'modules/claims_api/app/models/claims_api/supporting_document.rb'
     - 'modules/dhp_connected_devices/app/models/veteran_device_record.rb'
 
-# Offense count: 157
+# Offense count: 156
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/RootPathnameMethods:
   Exclude:
@@ -1190,7 +1210,6 @@ Rails/RootPathnameMethods:
     - 'modules/claims_api/spec/support/swagger_shared_components/v1.rb'
     - 'modules/claims_api/spec/support/swagger_shared_components/v2.rb'
     - 'modules/mobile/spec/models/adapters/appointments_vaos_v2_adapter_spec.rb'
-    - 'modules/mobile/spec/request/appointments_vaos_v2_list_request_spec.rb'
     - 'modules/mobile/spec/request/claims_document_upload_spec.rb'
     - 'modules/va_forms/app/workers/va_forms/form_reloader.rb'
     - 'modules/va_forms/lib/tasks/va_forms.rake'
@@ -1237,6 +1256,7 @@ Rails/UniqueValidationWithoutIndex:
 
 # Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
 Style/CollectionCompact:
   Exclude:
     - 'lib/saml/user_attributes/ssoe.rb'
@@ -1450,11 +1470,20 @@ Style/RedundantConstantBase:
     - 'spec/requests/swagger_spec.rb'
     - 'spec/serializers/evss_claim_detail_serializer_spec.rb'
 
-# Offense count: 1
+# Offense count: 10
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantSelfAssignmentBranch:
   Exclude:
+    - 'app/controllers/concerns/accountable.rb'
+    - 'app/controllers/v0/messages_controller.rb'
+    - 'app/controllers/v0/prescriptions_controller.rb'
+    - 'modules/claims_api/lib/claims_api/v2/disability_compensation_evss_mapper.rb'
     - 'modules/meb_api/lib/dgi/status/service.rb'
+    - 'modules/mobile/app/controllers/mobile/v0/messages_controller.rb'
+    - 'modules/mobile/app/controllers/mobile/v0/prescriptions_controller.rb'
+    - 'modules/my_health/app/controllers/my_health/v1/messages_controller.rb'
+    - 'modules/my_health/app/controllers/my_health/v1/prescriptions_controller.rb'
+    - 'spec/support/authenticated_session_helper.rb'
 
 # Offense count: 28
 # This cop supports safe autocorrection (--autocorrect).

Gemfile.lock

@@ -563,6 +563,7 @@ GEM
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
+    language_server-protocol (3.17.0.3)
     libdatadog (2.0.0.1.0)
     libdatadog (2.0.0.1.0-x86_64-linux)
     libddwaf (1.6.2.0.0)
@@ -824,14 +825,15 @@ GEM
     rswag-ui (2.9.0)
       actionpack (>= 3.1, < 7.1)
       railties (>= 3.1, < 7.1)
-    rubocop (1.45.1)
+    rubocop (1.53.0)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.24.1, < 2.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.29.0)